feat: Make Kafka topic numPartitions and replicationFactor configurable#2086
Merged
Conversation
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ewTopic in OsProcessManagerTest Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
ferenc-csaky
requested changes
May 21, 2026
Collaborator
ferenc-csaky
left a comment
There was a problem hiding this comment.
Logic itself LG, added 2 improvement suggestions.
…on default-package.json for kafka partition defaults Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…Factor Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
ferenc-csaky
approved these changes
May 21, 2026
…d d othe same in `DatasqrlRun`
82705ab to
33d6d98
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2086 +/- ##
=========================================
Coverage 13.52% 13.52%
- Complexity 841 842 +1
=========================================
Files 605 605
Lines 17297 17304 +7
Branches 2091 2091
=========================================
+ Hits 2340 2341 +1
- Misses 14741 14747 +6
Partials 216 216 ☔ View full report in Codecov by Sentry. |
ferenc-csaky
added a commit
that referenced
this pull request
May 21, 2026
…le (#2086) Co-authored-by: Ferenc Csaky <ferenc@datasqrl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.kafka.num-partitions(default1) andengines.kafka.replication-factor(default3) todefault-package.jsonKafkaLogEnginereads them from the engine config and propagates them to both subscription/mutation topics