Skip to content

feat: Make Kafka topic numPartitions and replicationFactor configurable#2086

Merged
ferenc-csaky merged 6 commits into
mainfrom
feat/configurable-kafka-partitions
May 21, 2026
Merged

feat: Make Kafka topic numPartitions and replicationFactor configurable#2086
ferenc-csaky merged 6 commits into
mainfrom
feat/configurable-kafka-partitions

Conversation

@velo
Copy link
Copy Markdown
Collaborator

@velo velo commented May 21, 2026

Summary

  • Adds engines.kafka.num-partitions (default 1) and engines.kafka.replication-factor (default 3) to default-package.json
  • KafkaLogEngine reads them from the engine config and propagates them to both subscription/mutation topics
  • The test-runner topics are restricted to 1 partition and 1 replication factor

velo added 2 commits May 21, 2026 09:30
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ewTopic in OsProcessManagerTest

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@velo velo enabled auto-merge (squash) May 21, 2026 12:47
@velo velo requested a review from ferenc-csaky May 21, 2026 12:47
Copy link
Copy Markdown
Collaborator

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic itself LG, added 2 improvement suggestions.

Comment thread sqrl-planner/src/main/java/com/datasqrl/engine/log/kafka/KafkaLogEngine.java Outdated
velo added 2 commits May 21, 2026 09:57
…on default-package.json for kafka partition defaults

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…Factor

Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
@ferenc-csaky ferenc-csaky force-pushed the feat/configurable-kafka-partitions branch from 82705ab to 33d6d98 Compare May 21, 2026 16:42
@ferenc-csaky ferenc-csaky disabled auto-merge May 21, 2026 16:45
@ferenc-csaky ferenc-csaky enabled auto-merge (squash) May 21, 2026 17:07
@ferenc-csaky ferenc-csaky merged commit 33ba2e3 into main May 21, 2026
16 checks passed
@ferenc-csaky ferenc-csaky deleted the feat/configurable-kafka-partitions branch May 21, 2026 17:17
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.52%. Comparing base (50acbc3) to head (a9ad6cf).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/java/com/datasqrl/engine/log/kafka/NewTopic.java 14.28% 6 Missing ⚠️
...li/src/main/java/com/datasqrl/cli/DatasqrlRun.java 0.00% 5 Missing ⚠️
.../com/datasqrl/engine/log/kafka/KafkaLogEngine.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2086   +/-   ##
=========================================
  Coverage     13.52%   13.52%           
- Complexity      841      842    +1     
=========================================
  Files           605      605           
  Lines         17297    17304    +7     
  Branches       2091     2091           
=========================================
+ Hits           2340     2341    +1     
- Misses        14741    14747    +6     
  Partials        216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ferenc-csaky added a commit that referenced this pull request May 21, 2026
…le (#2086)

Co-authored-by: Ferenc Csaky <ferenc@datasqrl.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants