Skip to content

fix(crashtracker): move preload logger marking after recursive guard #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gyuheon0h merged 2 commits into from
May 22, 2026
+5 −6
Merged

fix(crashtracker): move preload logger marking after recursive guard #2023

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a72305
Move preload logger after one time guard
gyuheon0h May 21, 2026
08ea319
Merge branch 'main' into gyuheon0h/PROF-14734-preload-logger-fail-inf…
gyuheon0h May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions libdd-crashtracker/src/collector/crash_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,6 @@ fn handle_posix_signal_impl(
return Ok(());
}

// Mark this process as a collector for the preload logger
#[cfg(target_os = "linux")]
{
super::api::mark_preload_logger_collector();
}

// If this code hits a stack overflow, then it will result in a segfault. That situation is
// protected by the one-time guard.

Expand All @@ -264,6 +258,11 @@ fn handle_posix_signal_impl(
return Ok(());
}

#[cfg(target_os = "linux")]
{
super::api::mark_preload_logger_collector();
}

// Suppress SIGPIPE and defer SIGCHLD during crash handling.
// SIGCHLD is block-only because SIG_IGN changes child reaping semantics (waitpid/ECHILD),
// which can interfere with receiver/collector process cleanup.
Expand Down
Loading