Skip to content

fix(cargo): include resolver config in .cargo/config.toml#235

Merged
iunanua merged 1 commit into
mainfrom
igor/cargo-config
May 26, 2026
Merged

fix(cargo): include resolver config in .cargo/config.toml#235
iunanua merged 1 commit into
mainfrom
igor/cargo-config

Conversation

@iunanua

@iunanua iunanua commented May 22, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Change the cargo resolver behavior

It controls what happens when a dependency's latest version declares a rust-version higher than your workspace's MSRV.

Two modes:

  • "allow" (default): Cargo always picks the newest semver-compatible version, even if it requires a newer compiler than your MSRV. Build then fails with a confusing compiler error.
  • "fallback" (what's set here): Cargo prefers the newest version whose declared rust-version is ≤ your workspace MSRV. It falls back to an older release of that crate rather than picking one you can't compile.

Motivation

libdd-trace-utils depends on httpmock@^0.8.0-alpha.1, and the latest httpmock@0.8.3 version raised MSRV to 1.88.
cargo update pulls 0.8.3 version breaking the build (of the tests) because the tracer's MSRV is 1.87.0

@iunanua iunanua changed the title fix(cargo): Include resolver config in .cargo/config.toml fix(cargo): include resolver config in .cargo/config.toml May 22, 2026
@datadog-official

datadog-official Bot commented May 22, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

pr-name | pr_name_lint   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. PR title linting failed: subject must not be sentence-case, start-case, pascal-case, upper-case

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d22e7eb | Docs | Datadog PR Page | Give us feedback!

@iunanua iunanua marked this pull request as ready for review May 26, 2026 15:32
@iunanua iunanua requested a review from a team as a code owner May 26, 2026 15:32
@iunanua iunanua merged commit 9b3ddcb into main May 26, 2026
31 of 34 checks passed
@iunanua iunanua deleted the igor/cargo-config branch May 26, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants