refactor(sampling): replace in-tree sampling with libdd-sampling#233
Closed
Aaalibaba42 wants to merge 1 commit into
Closed
refactor(sampling): replace in-tree sampling with libdd-sampling#233Aaalibaba42 wants to merge 1 commit into
Aaalibaba42 wants to merge 1 commit into
Conversation
|
21a376f to
3b9b289
Compare
Collaborator
|
Closing this as it is a duplicata of #154 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace
dd-trace-rs' local sampling implementation with the sharedlibdd-samplingcrate from libdatadog (introduced in #1927).Why
The sampling logic was hoisted into libdatadog so it can be reused across tracers. Keeping a
duplicate copy in dd-trace-rs means divergence risk and double maintenance burden.
How
core::samplingmodule with direct imports fromlibdd_sampling.core::constantswith a re-export oflibdd_sampling::dd_constants.SamplingRuleConfigfromlibdd_samplingin the configuration module.otel_mappings.rsto the new trait API:ValueLikemethod renames (extract_float->as_float,extract_string->as_str).SpanProperties::Attributeis now a GAT (type Attribute<'a>).#[repr(transparent)]newtype wrappers (OtelKeyValue,OtelValue,OtelTraceId) to satisfy orphan rules when implementing libdd-sampling traits forOpenTelemetry types.
lrudirect dependency (now transitive via libdd-sampling).Additional Notes