fix(tracing): handle env var values containing =#18137
Conversation
BenchmarksBenchmark execution time: 2026-05-18 15:04:52 Comparing candidate commit 6353bcd in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 591 metrics, 10 unstable metrics. scenario:iastaspects-stringio_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
…ubbing `[A-Z_]+` excluded digits, so names like `BASE64` were not recognised as env-var tokens and their values were never redacted.
Codeowners resolved as |
🎉 All green!🧪 All tests passed 🔗 Commit SHA: b0115b2 | Docs | Datadog PR Page | Give us feedback! |
|
/merge -f --reason "MQ failing for unrelated reasons (benchmark SLOs)" |
|
View all feedbacks in Devflow UI.
The expected merge time in
Warning This change was merged without running any pre merge CI checks Reason: MQ failing for unrelated reasons (benchmark SLOs) |
Description
Previously, we would
splitwithout a component count limit, meaning if we hadENV=something=elsean exception would be raised and we would fail to process it. Added a limit of 2 components so that we get the env variable name and discard all the rest, making it safer.On top of that, the PR adds support for env var names containing digits -- those didn't use to match the regex and were thus ignored from scrubbing.