fix(loguru): don't leak record[extra] into the record top level on opt-out#18136
Draft
KowalskiThomas wants to merge 1 commit into
Draft
Conversation
KowalskiThomas
force-pushed
the
kowalski/fix-loguru-dont-leak-record-extra-into-the-record-top-level-on-opt-out
branch
from
70caca7 to
1692dfb
Compare
Codeowners resolved as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
log injection is opt-out for structured logging. Return an empty dict so the caller's
record.update(...)is a no-op — previously this branch returnedevent_dictitself (=record["extra"]), which made the patcher copy every user-providedextrakey into the log record's top level for users who had explicitly disabled injection.