Skip to content

chore: ensure debugging is strictly typed#18133

Open
P403n1x87 wants to merge 1 commit into
mainfrom
chore/debugging-strict-mypy
Open

chore: ensure debugging is strictly typed#18133
P403n1x87 wants to merge 1 commit into
mainfrom
chore/debugging-strict-mypy

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We remove the mypy overrides to allow typing checks to cover ddtrace.debugging with the new strict mode.

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 18, 2026

Codeowners resolved as

ddtrace/debugging/_config.py                                            @DataDog/debugger-python
ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_encoding.py                                          @DataDog/debugger-python
ddtrace/debugging/_exception/replay.py                                  @DataDog/debugger-python
ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
ddtrace/debugging/_function/discovery.py                                @DataDog/debugger-python
ddtrace/debugging/_import.py                                            @DataDog/debugger-python
ddtrace/debugging/_origin/span.py                                       @DataDog/debugger-python
ddtrace/debugging/_probe/model.py                                       @DataDog/debugger-python
ddtrace/debugging/_probe/registry.py                                    @DataDog/debugger-python
ddtrace/debugging/_probe/remoteconfig.py                                @DataDog/debugger-python
ddtrace/debugging/_probe/status.py                                      @DataDog/debugger-python
ddtrace/debugging/_products/dynamic_instrumentation.py                  @DataDog/debugger-python
ddtrace/debugging/_products/exception_replay.py                         @DataDog/debugger-python
ddtrace/debugging/_products/live_debugger.py                            @DataDog/debugger-python
ddtrace/debugging/_signal/snapshot.py                                   @DataDog/debugger-python
ddtrace/debugging/_signal/tracing.py                                    @DataDog/debugger-python
ddtrace/debugging/_signal/utils.py                                      @DataDog/debugger-python
ddtrace/debugging/_uploader.py                                          @DataDog/debugger-python
ddtrace/internal/remoteconfig/worker.py                                 @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/runtime/__init__.py                                    @DataDog/apm-sdk-capabilities-python
ddtrace/internal/settings/dynamic_instrumentation.py                    @DataDog/debugger-python
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels May 18, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 18, 2026

Benchmarks

Benchmark execution time: 2026-05-18 15:26:43

Comparing candidate commit 9759406 in PR branch chore/debugging-strict-mypy with baseline commit 7ec0ac7 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 370 metrics, 9 unstable metrics.

scenario:span-start

  • 🟥 execution_time [+1.422ms; +1.546ms] or [+9.171%; +9.973%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+250.959ns; +281.788ns] or [+12.245%; +13.749%]

@P403n1x87 P403n1x87 force-pushed the chore/debugging-strict-mypy branch from f4aa5f0 to a015357 Compare May 18, 2026 14:06
We remove the mypy overrides to allow typing checks to cover
ddtrace.debugging with the new strict mode.
@P403n1x87 P403n1x87 force-pushed the chore/debugging-strict-mypy branch from a015357 to 9759406 Compare May 18, 2026 14:56
@P403n1x87 P403n1x87 marked this pull request as ready for review May 18, 2026 15:10
@P403n1x87 P403n1x87 requested review from a team as code owners May 18, 2026 15:10
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants