Skip to content

chore: make threads free-threaded-compatible#18114

Open
P403n1x87 wants to merge 2 commits into
mainfrom
chore/threads-free-threaded
Open

chore: make threads free-threaded-compatible#18114
P403n1x87 wants to merge 2 commits into
mainfrom
chore/threads-free-threaded

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We make sure that our periodic threads are compatible with the free-threaded builds of CPython.

We make sure that our periodic threads are compatible with the
free-threaded builds of CPython.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label May 15, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 15, 2026

Codeowners resolved as

ddtrace/internal/_threads.cpp                                           @DataDog/apm-core-python

@P403n1x87 P403n1x87 added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label May 15, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 15, 2026

Benchmarks

Benchmark execution time: 2026-05-15 21:01:04

Comparing candidate commit d982433 in PR branch chore/threads-free-threaded with baseline commit 1ab9c6f in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 595 metrics, 10 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+253.313µs; +296.225µs] or [+7.278%; +8.511%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+581.722µs; +623.330µs] or [+14.927%; +15.995%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+97.392µs; +103.739µs] or [+22.284%; +23.737%]

scenario:span-start

  • 🟥 execution_time [+1.397ms; +1.555ms] or [+8.940%; +9.949%]

@P403n1x87 P403n1x87 marked this pull request as ready for review May 15, 2026 18:14
@P403n1x87 P403n1x87 requested a review from a team as a code owner May 15, 2026 18:14
@P403n1x87 P403n1x87 requested a review from brettlangdon May 15, 2026 18:14
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70a3068dfd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/internal/_threads.cpp
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1-2 Bot commented May 15, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d982433 | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant