Skip to content

ci: make span start max_rss SLO consistent across scenarios#18112

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/bump.max_rss.lso
May 18, 2026
Merged

ci: make span start max_rss SLO consistent across scenarios#18112
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/bump.max_rss.lso

Conversation

@brettlangdon
Copy link
Copy Markdown
Member

Description

We are seeing some wider ranges than these SLOs, so updating the max_rss to be consistent across all the SLOs. Seems some of them need a slightly higher limit anyway.

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested a review from a team as a code owner May 15, 2026 14:26
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 15, 2026
@brettlangdon brettlangdon requested a review from a team as a code owner May 15, 2026 14:26
@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 Bot commented May 15, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🚧 96 tests that failed were ignored due to quarantine View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 008af0c | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 15, 2026

Benchmarks

Benchmark execution time: 2026-05-15 14:40:52

Comparing candidate commit 008af0c in PR branch brettlangdon/bump.max_rss.lso with baseline commit 1ab9c6f in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 593 metrics, 10 unstable metrics.

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+582.479µs; +629.633µs] or [+14.961%; +16.173%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+98.029µs; +104.155µs] or [+22.489%; +23.894%]

scenario:span-start

  • 🟥 execution_time [+1.499ms; +1.674ms] or [+9.661%; +10.789%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+167.217ns; +195.143ns] or [+7.952%; +9.280%]

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 70b1fde into main May 18, 2026
1106 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the brettlangdon/bump.max_rss.lso branch May 18, 2026 15:43
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

.gitlab/benchmarks/bp-runner.microbenchmarks.fail-on-breach.template.yml  @DataDog/python-guild @DataDog/apm-core-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants