Skip to content

fix(appsec): add WAF and RASP duration telemetry#18110

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
florentin.labelle/missing-waf-and-rasp-telemetry
May 19, 2026
Merged

fix(appsec): add WAF and RASP duration telemetry#18110
gh-worker-dd-mergequeue-cf854d[bot] merged 4 commits into
mainfrom
florentin.labelle/missing-waf-and-rasp-telemetry

Conversation

@florentinl
Copy link
Copy Markdown
Contributor

@florentinl florentinl commented May 15, 2026

APPSEC-62670
APPSEC-62671

Description

Adds AppSec instrumentation telemetry distributions for WAF and RASP execution durations, matching tracer-wide semantics by reporting aggregate request/context values with event_rules_version and waf_version tags.

Testing

  • Passes regular dd-trace-py unit tests

Risks

Low. Telemetry-only change; no tracing payload or blocking behavior changes.

Additional Notes

Includes release note.

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/appsec/_asm_request_context.py                                  @DataDog/asm-python
releasenotes/notes/appsec-waf-rasp-duration-telemetry-9d214f6730b34ad1.yaml  @DataDog/apm-python
tests/appsec/appsec/test_telemetry.py                                   @DataDog/asm-python

@florentinl florentinl force-pushed the florentin.labelle/missing-waf-and-rasp-telemetry branch from 741ba96 to b0dd169 Compare May 15, 2026 13:27
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 15, 2026

Benchmarks

Benchmark execution time: 2026-05-19 07:10:41

Comparing candidate commit c8ec992 in PR branch florentin.labelle/missing-waf-and-rasp-telemetry with baseline commit f0f5ba0 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 66 metrics, 0 unstable metrics.

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+104.586µs; +110.805µs] or [+24.017%; +25.446%]

@florentinl florentinl marked this pull request as ready for review May 18, 2026 08:16
@florentinl florentinl requested review from a team as code owners May 18, 2026 08:16
@florentinl florentinl requested review from mabdinur and taegyunkim May 18, 2026 08:16
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3333793d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddtrace/appsec/_asm_request_context.py
@florentinl
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 18, 2026

View all feedbacks in Devflow UI.

2026-05-18 08:52:55 UTC ℹ️ Start processing command /merge


2026-05-18 08:53:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).


2026-05-18 10:53:35 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

@florentinl
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 18, 2026

View all feedbacks in Devflow UI.

2026-05-18 11:31:57 UTC ℹ️ Start processing command /merge


2026-05-18 11:32:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 52m (p90).


2026-05-18 13:32:37 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

@datadog-prod-us1-4
Copy link
Copy Markdown
Contributor

datadog-prod-us1-4 Bot commented May 18, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c8ec992 | Docs | Datadog PR Page | Give us feedback!

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 951bfd0 into main May 19, 2026
606 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the florentin.labelle/missing-waf-and-rasp-telemetry branch May 19, 2026 09:21
vlad-scherbich pushed a commit that referenced this pull request May 20, 2026
## Description

Adds AppSec instrumentation telemetry distributions for WAF and RASP execution durations, matching tracer-wide semantics by reporting aggregate request/context values with `event_rules_version` and `waf_version` tags.

## Testing

- Passes regular dd-trace-py unit tests

## Risks

Low. Telemetry-only change; no tracing payload or blocking behavior changes.

## Additional Notes

Includes release note.

Co-authored-by: florentin.labelle <florentin.labelle@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants