-
Notifications
You must be signed in to change notification settings - Fork 320
Minor code cleanup: spaces, imports, etc. #10203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092359
Total [baseline] (11.06 s) : 0, 11059540
Agent [candidate] (1.079 s) : 0, 1079425
Total [candidate] (10.856 s) : 0, 10856378
section appsec
Agent [baseline] (1.266 s) : 0, 1265866
Total [baseline] (10.944 s) : 0, 10943541
Agent [candidate] (1.269 s) : 0, 1269232
Total [candidate] (10.957 s) : 0, 10956541
section iast
Agent [baseline] (1.23 s) : 0, 1229647
Total [baseline] (11.21 s) : 0, 11209518
Agent [candidate] (1.226 s) : 0, 1226393
Total [candidate] (11.261 s) : 0, 11261300
section profiling
Agent [baseline] (1.211 s) : 0, 1211440
Total [baseline] (10.975 s) : 0, 10975424
Agent [candidate] (1.208 s) : 0, 1208309
Total [candidate] (10.902 s) : 0, 10902031
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (655.024 ms) : 0, 655024
BytebuddyAgent [candidate] (648.048 ms) : 0, 648048
GlobalTracer [baseline] (284.916 ms) : 0, 284916
GlobalTracer [candidate] (280.975 ms) : 0, 280975
AppSec [baseline] (32.919 ms) : 0, 32919
AppSec [candidate] (32.248 ms) : 0, 32248
Debugger [baseline] (68.978 ms) : 0, 68978
Debugger [candidate] (67.991 ms) : 0, 67991
Remote Config [baseline] (653.729 µs) : 0, 654
Remote Config [candidate] (625.699 µs) : 0, 626
Telemetry [baseline] (9.191 ms) : 0, 9191
Telemetry [candidate] (9.09 ms) : 0, 9090
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (3.798 ms) : 0, 3798
section appsec
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (689.787 ms) : 0, 689787
BytebuddyAgent [candidate] (693.846 ms) : 0, 693846
GlobalTracer [baseline] (258.976 ms) : 0, 258976
GlobalTracer [candidate] (259.112 ms) : 0, 259112
AppSec [baseline] (175.065 ms) : 0, 175065
AppSec [candidate] (174.679 ms) : 0, 174679
Debugger [baseline] (66.972 ms) : 0, 66972
Debugger [candidate] (66.269 ms) : 0, 66269
Remote Config [baseline] (732.377 µs) : 0, 732
Remote Config [candidate] (688.528 µs) : 0, 689
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.107 ms) : 0, 9107
Flare Poller [baseline] (3.879 ms) : 0, 3879
Flare Poller [candidate] (3.892 ms) : 0, 3892
IAST [baseline] (24.582 ms) : 0, 24582
IAST [candidate] (24.732 ms) : 0, 24732
section iast
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (795.854 ms) : 0, 795854
BytebuddyAgent [candidate] (794.857 ms) : 0, 794857
GlobalTracer [baseline] (257.425 ms) : 0, 257425
GlobalTracer [candidate] (255.912 ms) : 0, 255912
AppSec [baseline] (35.256 ms) : 0, 35256
AppSec [candidate] (34.931 ms) : 0, 34931
Debugger [baseline] (64.911 ms) : 0, 64911
Debugger [candidate] (64.728 ms) : 0, 64728
Remote Config [baseline] (542.473 µs) : 0, 542
Remote Config [candidate] (544.404 µs) : 0, 544
Telemetry [baseline] (8.39 ms) : 0, 8390
Telemetry [candidate] (8.351 ms) : 0, 8351
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.431 ms) : 0, 3431
IAST [baseline] (27.021 ms) : 0, 27021
IAST [candidate] (26.899 ms) : 0, 26899
section profiling
ProfilingAgent [baseline] (97.94 ms) : 0, 97940
ProfilingAgent [candidate] (97.477 ms) : 0, 97477
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (705.438 ms) : 0, 705438
BytebuddyAgent [candidate] (702.947 ms) : 0, 702947
GlobalTracer [baseline] (221.817 ms) : 0, 221817
GlobalTracer [candidate] (222.459 ms) : 0, 222459
AppSec [baseline] (32.504 ms) : 0, 32504
AppSec [candidate] (32.619 ms) : 0, 32619
Debugger [baseline] (68.712 ms) : 0, 68712
Debugger [candidate] (68.341 ms) : 0, 68341
Remote Config [baseline] (665.316 µs) : 0, 665
Remote Config [candidate] (634.768 µs) : 0, 635
Telemetry [baseline] (9.158 ms) : 0, 9158
Telemetry [candidate] (8.978 ms) : 0, 8978
Flare Poller [baseline] (3.768 ms) : 0, 3768
Flare Poller [candidate] (3.79 ms) : 0, 3790
Profiling [baseline] (98.527 ms) : 0, 98527
Profiling [candidate] (98.053 ms) : 0, 98053
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1078283
Total [baseline] (8.785 s) : 0, 8784728
Agent [candidate] (1.079 s) : 0, 1078540
Total [candidate] (8.777 s) : 0, 8777004
section iast
Agent [baseline] (1.223 s) : 0, 1222537
Total [baseline] (9.373 s) : 0, 9373470
Agent [candidate] (1.231 s) : 0, 1230883
Total [candidate] (9.405 s) : 0, 9405485
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (647.511 ms) : 0, 647511
BytebuddyAgent [candidate] (648.169 ms) : 0, 648169
GlobalTracer [baseline] (281.139 ms) : 0, 281139
GlobalTracer [candidate] (281.479 ms) : 0, 281479
AppSec [baseline] (32.29 ms) : 0, 32290
AppSec [candidate] (32.172 ms) : 0, 32172
Debugger [baseline] (67.249 ms) : 0, 67249
Debugger [candidate] (66.641 ms) : 0, 66641
Remote Config [baseline] (629.299 µs) : 0, 629
Remote Config [candidate] (643.956 µs) : 0, 644
Telemetry [baseline] (9.019 ms) : 0, 9019
Telemetry [candidate] (9.028 ms) : 0, 9028
Flare Poller [baseline] (3.75 ms) : 0, 3750
Flare Poller [candidate] (3.699 ms) : 0, 3699
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (791.207 ms) : 0, 791207
BytebuddyAgent [candidate] (796.847 ms) : 0, 796847
GlobalTracer [baseline] (255.892 ms) : 0, 255892
GlobalTracer [candidate] (257.429 ms) : 0, 257429
AppSec [baseline] (35.361 ms) : 0, 35361
AppSec [candidate] (34.578 ms) : 0, 34578
Debugger [baseline] (63.984 ms) : 0, 63984
Debugger [candidate] (65.53 ms) : 0, 65530
Remote Config [baseline] (553.077 µs) : 0, 553
Remote Config [candidate] (574.881 µs) : 0, 575
Telemetry [baseline] (8.4 ms) : 0, 8400
Telemetry [candidate] (8.473 ms) : 0, 8473
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.504 ms) : 0, 3504
IAST [baseline] (27.021 ms) : 0, 27021
IAST [candidate] (27.341 ms) : 0, 27341
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section baseline
no_agent (19.083 ms) : 18888, 19279
. : milestone, 19083,
appsec (18.79 ms) : 18593, 18986
. : milestone, 18790,
code_origins (18.049 ms) : 17870, 18229
. : milestone, 18049,
iast (17.906 ms) : 17726, 18086
. : milestone, 17906,
profiling (18.884 ms) : 18695, 19073
. : milestone, 18884,
tracing (18.237 ms) : 18049, 18425
. : milestone, 18237,
section candidate
no_agent (18.032 ms) : 17849, 18215
. : milestone, 18032,
appsec (18.57 ms) : 18384, 18757
. : milestone, 18570,
code_origins (18.691 ms) : 18505, 18876
. : milestone, 18691,
iast (17.752 ms) : 17576, 17928
. : milestone, 17752,
profiling (19.707 ms) : 19506, 19908
. : milestone, 19707,
tracing (17.921 ms) : 17741, 18101
. : milestone, 17921,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section baseline
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.225 ms) : 3187, 3264
. : milestone, 3225,
iast_FULL (5.758 ms) : 5700, 5815
. : milestone, 5758,
iast_GLOBAL (3.64 ms) : 3587, 3693
. : milestone, 3640,
profiling (1.978 ms) : 1960, 1996
. : milestone, 1978,
tracing (1.79 ms) : 1776, 1803
. : milestone, 1790,
section candidate
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.259 ms) : 3216, 3302
. : milestone, 3259,
iast_FULL (5.772 ms) : 5714, 5830
. : milestone, 5772,
iast_GLOBAL (3.629 ms) : 3569, 3690
. : milestone, 3629,
profiling (2.114 ms) : 2096, 2133
. : milestone, 2114,
tracing (1.813 ms) : 1797, 1828
. : milestone, 1813,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.71 ms) : 3491, 3928
. : milestone, 3710,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.255 ms) : 2190, 2320
. : milestone, 2255,
profiling (2.076 ms) : 2022, 2129
. : milestone, 2076,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.703 ms) : 3485, 3921
. : milestone, 3703,
iast (2.214 ms) : 2149, 2279
. : milestone, 2214,
iast_GLOBAL (2.258 ms) : 2192, 2324
. : milestone, 2258,
profiling (2.447 ms) : 2238, 2655
. : milestone, 2447,
tracing (2.053 ms) : 2001, 2104
. : milestone, 2053,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~e06bf55a69, baseline=1.57.0-SNAPSHOT~d055d9238e
dateFormat X
axisFormat %s
section baseline
no_agent (14.878 s) : 14878000, 14878000
. : milestone, 14878000,
appsec (14.857 s) : 14857000, 14857000
. : milestone, 14857000,
iast (17.964 s) : 17964000, 17964000
. : milestone, 17964000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (14.686 s) : 14686000, 14686000
. : milestone, 14686000,
tracing (14.618 s) : 14618000, 14618000
. : milestone, 14618000,
section candidate
no_agent (15.296 s) : 15296000, 15296000
. : milestone, 15296000,
appsec (14.845 s) : 14845000, 14845000
. : milestone, 14845000,
iast (18.204 s) : 18204000, 18204000
. : milestone, 18204000,
iast_GLOBAL (17.809 s) : 17809000, 17809000
. : milestone, 17809000,
profiling (14.687 s) : 14687000, 14687000
. : milestone, 14687000,
tracing (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
|
What Does This Do
Minor code cleanup: spaces, imports, etc.
Motivation
Clean code.
Additional Notes
Found those not needed
;or wrong imports during PR reviews and playing with spotless locally.