-
Notifications
You must be signed in to change notification settings - Fork 324
Clean workflow and trust policy #10200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: When checking if the branch already exits, it could be nice to use an error message then exit the pipeline:
echo "::error:: Branch $BRANCH already exists - please delete it and re-run the workflow." && exit 1
And later && steps.check-branch.outputs.creating_new_branch == 'true' checks will be no more needed.
👏 praise: Good job, not an easy automation to pull off! You should share is more widely with the other dd-trace-* repos 😉
Good idea! I used the same concept for checking if there is anything to commit as well (5422f0c). It makes sense to me for the pipeline to fail in all cases except when a PR that pins system tests is actually created.
Team work makes the dream work - thanks for iterating with me! And sounds good - will do once the next release (hopefully) confirms that this works 🙂 |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091601
Total [baseline] (10.789 s) : 0, 10789292
Agent [candidate] (1.08 s) : 0, 1080224
Total [candidate] (10.751 s) : 0, 10751009
section appsec
Agent [baseline] (1.259 s) : 0, 1259264
Total [baseline] (10.837 s) : 0, 10837082
Agent [candidate] (1.271 s) : 0, 1271204
Total [candidate] (10.972 s) : 0, 10971516
section iast
Agent [baseline] (1.219 s) : 0, 1218940
Total [baseline] (11.148 s) : 0, 11148376
Agent [candidate] (1.231 s) : 0, 1230861
Total [candidate] (11.18 s) : 0, 11180200
section profiling
Agent [baseline] (1.219 s) : 0, 1218821
Total [baseline] (11.011 s) : 0, 11011447
Agent [candidate] (1.202 s) : 0, 1201885
Total [candidate] (10.889 s) : 0, 10889245
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (656.787 ms) : 0, 656787
BytebuddyAgent [candidate] (648.525 ms) : 0, 648525
GlobalTracer [baseline] (283.914 ms) : 0, 283914
GlobalTracer [candidate] (281.142 ms) : 0, 281142
AppSec [baseline] (32.492 ms) : 0, 32492
AppSec [candidate] (32.26 ms) : 0, 32260
Debugger [baseline] (68.157 ms) : 0, 68157
Debugger [candidate] (68.293 ms) : 0, 68293
Remote Config [baseline] (632.833 µs) : 0, 633
Remote Config [candidate] (636.264 µs) : 0, 636
Telemetry [baseline] (9.003 ms) : 0, 9003
Telemetry [candidate] (8.999 ms) : 0, 8999
Flare Poller [baseline] (3.705 ms) : 0, 3705
Flare Poller [candidate] (3.711 ms) : 0, 3711
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (686.807 ms) : 0, 686807
BytebuddyAgent [candidate] (693.477 ms) : 0, 693477
GlobalTracer [baseline] (257.599 ms) : 0, 257599
GlobalTracer [candidate] (260.143 ms) : 0, 260143
AppSec [baseline] (174.308 ms) : 0, 174308
AppSec [candidate] (174.893 ms) : 0, 174893
Debugger [baseline] (65.951 ms) : 0, 65951
Debugger [candidate] (67.268 ms) : 0, 67268
Remote Config [baseline] (713.875 µs) : 0, 714
Remote Config [candidate] (744.254 µs) : 0, 744
Telemetry [baseline] (9.002 ms) : 0, 9002
Telemetry [candidate] (9.1 ms) : 0, 9100
Flare Poller [baseline] (3.77 ms) : 0, 3770
Flare Poller [candidate] (3.9 ms) : 0, 3900
IAST [baseline] (24.409 ms) : 0, 24409
IAST [candidate] (24.819 ms) : 0, 24819
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (789.264 ms) : 0, 789264
BytebuddyAgent [candidate] (796.46 ms) : 0, 796460
GlobalTracer [baseline] (254.721 ms) : 0, 254721
GlobalTracer [candidate] (257.369 ms) : 0, 257369
AppSec [baseline] (34.821 ms) : 0, 34821
AppSec [candidate] (35.362 ms) : 0, 35362
Debugger [baseline] (64.527 ms) : 0, 64527
Debugger [candidate] (65.129 ms) : 0, 65129
Remote Config [baseline] (551.932 µs) : 0, 552
Remote Config [candidate] (557.324 µs) : 0, 557
Telemetry [baseline] (8.343 ms) : 0, 8343
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (3.407 ms) : 0, 3407
Flare Poller [candidate] (3.527 ms) : 0, 3527
IAST [baseline] (26.893 ms) : 0, 26893
IAST [candidate] (27.325 ms) : 0, 27325
section profiling
ProfilingAgent [baseline] (97.374 ms) : 0, 97374
ProfilingAgent [candidate] (96.092 ms) : 0, 96092
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (711.346 ms) : 0, 711346
BytebuddyAgent [candidate] (701.309 ms) : 0, 701309
GlobalTracer [baseline] (223.305 ms) : 0, 223305
GlobalTracer [candidate] (220.568 ms) : 0, 220568
AppSec [baseline] (32.819 ms) : 0, 32819
AppSec [candidate] (31.999 ms) : 0, 31999
Debugger [baseline] (68.619 ms) : 0, 68619
Debugger [candidate] (67.858 ms) : 0, 67858
Remote Config [baseline] (635.622 µs) : 0, 636
Remote Config [candidate] (612.41 µs) : 0, 612
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (8.881 ms) : 0, 8881
Flare Poller [baseline] (3.768 ms) : 0, 3768
Flare Poller [candidate] (3.74 ms) : 0, 3740
Profiling [baseline] (97.96 ms) : 0, 97960
Profiling [candidate] (96.66 ms) : 0, 96660
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1075619
Total [baseline] (8.706 s) : 0, 8706277
Agent [candidate] (1.084 s) : 0, 1084021
Total [candidate] (8.791 s) : 0, 8791313
section iast
Agent [baseline] (1.216 s) : 0, 1215564
Total [baseline] (9.342 s) : 0, 9341880
Agent [candidate] (1.233 s) : 0, 1232925
Total [candidate] (9.383 s) : 0, 9383389
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (645.909 ms) : 0, 645909
BytebuddyAgent [candidate] (651.404 ms) : 0, 651404
GlobalTracer [baseline] (280.606 ms) : 0, 280606
GlobalTracer [candidate] (282.993 ms) : 0, 282993
AppSec [baseline] (32.151 ms) : 0, 32151
AppSec [candidate] (32.372 ms) : 0, 32372
Debugger [baseline] (66.896 ms) : 0, 66896
Debugger [candidate] (66.97 ms) : 0, 66970
Remote Config [baseline] (627.847 µs) : 0, 628
Remote Config [candidate] (628.293 µs) : 0, 628
Telemetry [baseline] (9.018 ms) : 0, 9018
Telemetry [candidate] (9.003 ms) : 0, 9003
Flare Poller [baseline] (3.752 ms) : 0, 3752
Flare Poller [candidate] (3.796 ms) : 0, 3796
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (787.379 ms) : 0, 787379
BytebuddyAgent [candidate] (801.101 ms) : 0, 801101
GlobalTracer [baseline] (254.389 ms) : 0, 254389
GlobalTracer [candidate] (256.505 ms) : 0, 256505
AppSec [baseline] (33.165 ms) : 0, 33165
AppSec [candidate] (33.526 ms) : 0, 33526
Debugger [baseline] (65.164 ms) : 0, 65164
Debugger [candidate] (65.712 ms) : 0, 65712
Remote Config [baseline] (533.321 µs) : 0, 533
Remote Config [candidate] (523.921 µs) : 0, 524
Telemetry [baseline] (8.356 ms) : 0, 8356
Telemetry [candidate] (8.348 ms) : 0, 8348
Flare Poller [baseline] (3.455 ms) : 0, 3455
Flare Poller [candidate] (3.46 ms) : 0, 3460
IAST [baseline] (26.656 ms) : 0, 26656
IAST [candidate] (27.09 ms) : 0, 27090
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section baseline
no_agent (18.156 ms) : 17968, 18344
. : milestone, 18156,
appsec (19.93 ms) : 19722, 20138
. : milestone, 19930,
code_origins (17.928 ms) : 17751, 18105
. : milestone, 17928,
iast (17.905 ms) : 17725, 18085
. : milestone, 17905,
profiling (18.881 ms) : 18691, 19072
. : milestone, 18881,
tracing (18.917 ms) : 18726, 19108
. : milestone, 18917,
section candidate
no_agent (18.336 ms) : 18148, 18524
. : milestone, 18336,
appsec (18.926 ms) : 18736, 19116
. : milestone, 18926,
code_origins (17.939 ms) : 17761, 18117
. : milestone, 17939,
iast (17.593 ms) : 17420, 17767
. : milestone, 17593,
profiling (18.57 ms) : 18384, 18757
. : milestone, 18570,
tracing (17.777 ms) : 17603, 17950
. : milestone, 17777,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1175, 1197
. : milestone, 1186,
iast (3.264 ms) : 3221, 3308
. : milestone, 3264,
iast_FULL (5.968 ms) : 5907, 6028
. : milestone, 5968,
iast_GLOBAL (3.636 ms) : 3584, 3687
. : milestone, 3636,
profiling (1.928 ms) : 1912, 1944
. : milestone, 1928,
tracing (1.806 ms) : 1791, 1821
. : milestone, 1806,
section candidate
no_agent (1.191 ms) : 1179, 1202
. : milestone, 1191,
iast (3.188 ms) : 3146, 3231
. : milestone, 3188,
iast_FULL (5.84 ms) : 5781, 5898
. : milestone, 5840,
iast_GLOBAL (3.616 ms) : 3559, 3672
. : milestone, 3616,
profiling (2.101 ms) : 2082, 2119
. : milestone, 2101,
tracing (1.849 ms) : 1833, 1864
. : milestone, 1849,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section baseline
no_agent (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
appsec (14.417 s) : 14417000, 14417000
. : milestone, 14417000,
iast (17.864 s) : 17864000, 17864000
. : milestone, 17864000,
iast_GLOBAL (17.781 s) : 17781000, 17781000
. : milestone, 17781000,
profiling (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
tracing (14.752 s) : 14752000, 14752000
. : milestone, 14752000,
section candidate
no_agent (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
appsec (14.995 s) : 14995000, 14995000
. : milestone, 14995000,
iast (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
iast_GLOBAL (18.044 s) : 18044000, 18044000
. : milestone, 18044000,
profiling (14.697 s) : 14697000, 14697000
. : milestone, 14697000,
tracing (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5422f0c245, baseline=1.57.0-SNAPSHOT~387d37dadc
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.671 ms) : 3456, 3886
. : milestone, 3671,
iast (2.22 ms) : 2156, 2284
. : milestone, 2220,
iast_GLOBAL (2.269 ms) : 2204, 2334
. : milestone, 2269,
profiling (2.11 ms) : 2056, 2164
. : milestone, 2110,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
section candidate
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (2.482 ms) : 2430, 2534
. : milestone, 2482,
iast (2.223 ms) : 2159, 2287
. : milestone, 2223,
iast_GLOBAL (2.279 ms) : 2213, 2345
. : milestone, 2279,
profiling (2.502 ms) : 2342, 2662
. : milestone, 2502,
tracing (2.058 ms) : 2007, 2109
. : milestone, 2058,
|
What Does This Do
Clean workflow and trust policy for pinning system tests on a release branch. This workflow is triggered either manually (tested via this pipeline and this PR) or when a
release/v**branch is created (tested with atest/v**branch via this pipeline and this PR)Motivation
Automate the creation of the PR that pins system tests to the release branch. This allows subsequent patch releases made off of this release branch to only need to pass the version of system tests that the original minor release was made off of.
Additional Notes
Please review the entire
.github/workflows/pin-system-tests.yamlworkflow file 🙂Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-598