-
Notifications
You must be signed in to change notification settings - Fork 320
Disable virtual thread instrumentation by default #10171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PerfectSlayer
wants to merge
1
commit into
master
Choose a base branch
from
bbujon/virtual-threads-disabled
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougqh
approved these changes
Dec 11, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1082189
Total [baseline] (10.85 s) : 0, 10850025
Agent [candidate] (1.08 s) : 0, 1079937
Total [candidate] (10.862 s) : 0, 10862391
section appsec
Agent [baseline] (1.263 s) : 0, 1263393
Total [baseline] (11.262 s) : 0, 11261593
Agent [candidate] (1.268 s) : 0, 1268286
Total [candidate] (11.139 s) : 0, 11138614
section iast
Agent [baseline] (1.223 s) : 0, 1223158
Total [baseline] (11.257 s) : 0, 11257388
Agent [candidate] (1.225 s) : 0, 1225218
Total [candidate] (11.088 s) : 0, 11087795
section profiling
Agent [baseline] (1.208 s) : 0, 1208429
Total [baseline] (11.005 s) : 0, 11005195
Agent [candidate] (1.213 s) : 0, 1213419
Total [candidate] (11.098 s) : 0, 11098083
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (649.188 ms) : 0, 649188
BytebuddyAgent [candidate] (648.204 ms) : 0, 648204
GlobalTracer [baseline] (281.611 ms) : 0, 281611
GlobalTracer [candidate] (281.242 ms) : 0, 281242
AppSec [baseline] (32.526 ms) : 0, 32526
AppSec [candidate] (32.208 ms) : 0, 32208
Debugger [baseline] (68.838 ms) : 0, 68838
Debugger [candidate] (68.235 ms) : 0, 68235
Remote Config [baseline] (629.383 µs) : 0, 629
Remote Config [candidate] (635.054 µs) : 0, 635
Telemetry [baseline] (8.962 ms) : 0, 8962
Telemetry [candidate] (9.038 ms) : 0, 9038
Flare Poller [baseline] (3.726 ms) : 0, 3726
Flare Poller [candidate] (3.716 ms) : 0, 3716
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.214 ms) : 0, 1214
BytebuddyAgent [baseline] (688.631 ms) : 0, 688631
BytebuddyAgent [candidate] (689.805 ms) : 0, 689805
GlobalTracer [baseline] (258.786 ms) : 0, 258786
GlobalTracer [candidate] (260.421 ms) : 0, 260421
IAST [baseline] (24.816 ms) : 0, 24816
IAST [candidate] (24.777 ms) : 0, 24777
AppSec [baseline] (174.603 ms) : 0, 174603
AppSec [candidate] (175.025 ms) : 0, 175025
Debugger [baseline] (66.253 ms) : 0, 66253
Debugger [candidate] (67.826 ms) : 0, 67826
Remote Config [baseline] (722.927 µs) : 0, 723
Remote Config [candidate] (702.306 µs) : 0, 702
Telemetry [baseline] (9.042 ms) : 0, 9042
Telemetry [candidate] (9.036 ms) : 0, 9036
Flare Poller [baseline] (3.927 ms) : 0, 3927
Flare Poller [candidate] (3.895 ms) : 0, 3895
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (790.639 ms) : 0, 790639
BytebuddyAgent [candidate] (792.056 ms) : 0, 792056
GlobalTracer [baseline] (255.657 ms) : 0, 255657
GlobalTracer [candidate] (256.128 ms) : 0, 256128
IAST [baseline] (26.868 ms) : 0, 26868
IAST [candidate] (26.918 ms) : 0, 26918
AppSec [baseline] (35.257 ms) : 0, 35257
AppSec [candidate] (35.329 ms) : 0, 35329
Debugger [baseline] (65.78 ms) : 0, 65780
Debugger [candidate] (65.826 ms) : 0, 65826
Remote Config [baseline] (538.667 µs) : 0, 539
Remote Config [candidate] (536.013 µs) : 0, 536
Telemetry [baseline] (8.397 ms) : 0, 8397
Telemetry [candidate] (8.419 ms) : 0, 8419
Flare Poller [baseline] (3.501 ms) : 0, 3501
Flare Poller [candidate] (3.493 ms) : 0, 3493
section profiling
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (703.805 ms) : 0, 703805
BytebuddyAgent [candidate] (706.821 ms) : 0, 706821
GlobalTracer [baseline] (221.84 ms) : 0, 221840
GlobalTracer [candidate] (221.893 ms) : 0, 221893
AppSec [baseline] (32.828 ms) : 0, 32828
AppSec [candidate] (32.625 ms) : 0, 32625
Debugger [baseline] (68.211 ms) : 0, 68211
Debugger [candidate] (68.634 ms) : 0, 68634
Remote Config [baseline] (623.365 µs) : 0, 623
Remote Config [candidate] (626.056 µs) : 0, 626
Telemetry [baseline] (9.018 ms) : 0, 9018
Telemetry [candidate] (9.049 ms) : 0, 9049
Flare Poller [baseline] (3.799 ms) : 0, 3799
Flare Poller [candidate] (3.78 ms) : 0, 3780
ProfilingAgent [baseline] (97.537 ms) : 0, 97537
ProfilingAgent [candidate] (98.274 ms) : 0, 98274
Profiling [baseline] (98.113 ms) : 0, 98113
Profiling [candidate] (98.851 ms) : 0, 98851
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081217
Total [baseline] (8.776 s) : 0, 8776492
Agent [candidate] (1.09 s) : 0, 1090281
Total [candidate] (8.783 s) : 0, 8782834
section iast
Agent [baseline] (1.216 s) : 0, 1215597
Total [baseline] (9.479 s) : 0, 9479371
Agent [candidate] (1.227 s) : 0, 1227027
Total [candidate] (9.511 s) : 0, 9511053
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (651.62 ms) : 0, 651620
BytebuddyAgent [candidate] (656.968 ms) : 0, 656968
GlobalTracer [baseline] (280.335 ms) : 0, 280335
GlobalTracer [candidate] (282.811 ms) : 0, 282811
AppSec [baseline] (32.132 ms) : 0, 32132
AppSec [candidate] (32.587 ms) : 0, 32587
Debugger [baseline] (67.024 ms) : 0, 67024
Debugger [candidate] (67.525 ms) : 0, 67525
Remote Config [baseline] (635.931 µs) : 0, 636
Remote Config [candidate] (640.656 µs) : 0, 641
Telemetry [baseline] (8.993 ms) : 0, 8993
Telemetry [candidate] (9.052 ms) : 0, 9052
Flare Poller [baseline] (3.701 ms) : 0, 3701
Flare Poller [candidate] (3.744 ms) : 0, 3744
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (785.912 ms) : 0, 785912
BytebuddyAgent [candidate] (795.696 ms) : 0, 795696
GlobalTracer [baseline] (254.411 ms) : 0, 254411
GlobalTracer [candidate] (255.411 ms) : 0, 255411
IAST [baseline] (26.821 ms) : 0, 26821
IAST [candidate] (26.974 ms) : 0, 26974
AppSec [baseline] (35.433 ms) : 0, 35433
AppSec [candidate] (35.24 ms) : 0, 35240
Debugger [baseline] (64.13 ms) : 0, 64130
Debugger [candidate] (64.604 ms) : 0, 64604
Remote Config [baseline] (534.992 µs) : 0, 535
Remote Config [candidate] (554.232 µs) : 0, 554
Telemetry [baseline] (8.406 ms) : 0, 8406
Telemetry [candidate] (8.407 ms) : 0, 8407
Flare Poller [baseline] (3.497 ms) : 0, 3497
Flare Poller [candidate] (3.473 ms) : 0, 3473
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section baseline
no_agent (19.589 ms) : 19391, 19787
. : milestone, 19589,
appsec (18.707 ms) : 18516, 18898
. : milestone, 18707,
code_origins (17.664 ms) : 17487, 17840
. : milestone, 17664,
iast (17.537 ms) : 17361, 17713
. : milestone, 17537,
profiling (19.444 ms) : 19247, 19641
. : milestone, 19444,
tracing (17.685 ms) : 17510, 17860
. : milestone, 17685,
section candidate
no_agent (19.538 ms) : 19336, 19740
. : milestone, 19538,
appsec (18.727 ms) : 18531, 18923
. : milestone, 18727,
code_origins (17.951 ms) : 17769, 18134
. : milestone, 17951,
iast (17.709 ms) : 17533, 17884
. : milestone, 17709,
profiling (18.607 ms) : 18420, 18795
. : milestone, 18607,
tracing (17.456 ms) : 17282, 17629
. : milestone, 17456,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.215 ms) : 1203, 1228
. : milestone, 1215,
iast (3.16 ms) : 3116, 3205
. : milestone, 3160,
iast_FULL (5.93 ms) : 5870, 5989
. : milestone, 5930,
iast_GLOBAL (3.716 ms) : 3652, 3780
. : milestone, 3716,
profiling (2.095 ms) : 2076, 2114
. : milestone, 2095,
tracing (1.817 ms) : 1802, 1833
. : milestone, 1817,
section candidate
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.133 ms) : 3093, 3173
. : milestone, 3133,
iast_FULL (5.98 ms) : 5919, 6042
. : milestone, 5980,
iast_GLOBAL (3.522 ms) : 3465, 3578
. : milestone, 3522,
profiling (2.144 ms) : 2124, 2163
. : milestone, 2144,
tracing (1.832 ms) : 1816, 1847
. : milestone, 1832,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section baseline
no_agent (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
appsec (14.718 s) : 14718000, 14718000
. : milestone, 14718000,
iast (18.48 s) : 18480000, 18480000
. : milestone, 18480000,
iast_GLOBAL (17.895 s) : 17895000, 17895000
. : milestone, 17895000,
profiling (14.906 s) : 14906000, 14906000
. : milestone, 14906000,
tracing (14.528 s) : 14528000, 14528000
. : milestone, 14528000,
section candidate
no_agent (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
appsec (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
iast (17.921 s) : 17921000, 17921000
. : milestone, 17921000,
iast_GLOBAL (17.85 s) : 17850000, 17850000
. : milestone, 17850000,
profiling (14.398 s) : 14398000, 14398000
. : milestone, 14398000,
tracing (14.844 s) : 14844000, 14844000
. : milestone, 14844000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~164a756639, baseline=1.57.0-SNAPSHOT~4a91aa783b
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.711 ms) : 3490, 3931
. : milestone, 3711,
iast (2.216 ms) : 2152, 2281
. : milestone, 2216,
iast_GLOBAL (2.261 ms) : 2196, 2326
. : milestone, 2261,
profiling (2.09 ms) : 2037, 2143
. : milestone, 2090,
tracing (2.052 ms) : 2001, 2103
. : milestone, 2052,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.717 ms) : 3496, 3937
. : milestone, 3717,
iast (2.224 ms) : 2158, 2289
. : milestone, 2224,
iast_GLOBAL (2.264 ms) : 2199, 2329
. : milestone, 2264,
profiling (2.131 ms) : 2074, 2188
. : milestone, 2131,
tracing (2.049 ms) : 1998, 2100
. : milestone, 2049,
|
bric3
approved these changes
Dec 12, 2025
AlexeyKuznetsov-DD
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: java
Core Java language instrumentation
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
There is a deadlock with groovy testing making them flaky.
I need time to properly test it and before activating the feature by default.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]