-
Notifications
You must be signed in to change notification settings - Fork 320
Enable Spark Plan metadata parsing by default #10169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
charlesmyu
wants to merge
1
commit into
master
Choose a base branch
from
charles.yu/djm-974/parse-plan-by-default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088754
Total [baseline] (11.037 s) : 0, 11037081
Agent [candidate] (1.081 s) : 0, 1080908
Total [candidate] (10.861 s) : 0, 10861293
section appsec
Agent [baseline] (1.274 s) : 0, 1273863
Total [baseline] (11.043 s) : 0, 11043015
Agent [candidate] (1.268 s) : 0, 1267887
Total [candidate] (11.136 s) : 0, 11136354
section iast
Agent [baseline] (1.239 s) : 0, 1239170
Total [baseline] (11.304 s) : 0, 11303631
Agent [candidate] (1.23 s) : 0, 1230143
Total [candidate] (11.313 s) : 0, 11313121
section profiling
Agent [baseline] (1.212 s) : 0, 1212319
Total [baseline] (10.933 s) : 0, 10933148
Agent [candidate] (1.204 s) : 0, 1203701
Total [candidate] (10.955 s) : 0, 10954824
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (653.562 ms) : 0, 653562
BytebuddyAgent [candidate] (648.235 ms) : 0, 648235
GlobalTracer [baseline] (283.318 ms) : 0, 283318
GlobalTracer [candidate] (281.864 ms) : 0, 281864
AppSec [baseline] (32.744 ms) : 0, 32744
AppSec [candidate] (32.49 ms) : 0, 32490
Debugger [baseline] (68.712 ms) : 0, 68712
Debugger [candidate] (68.248 ms) : 0, 68248
Remote Config [baseline] (639.976 µs) : 0, 640
Remote Config [candidate] (630.789 µs) : 0, 631
Telemetry [baseline] (9.074 ms) : 0, 9074
Telemetry [candidate] (9.057 ms) : 0, 9057
Flare Poller [baseline] (3.762 ms) : 0, 3762
Flare Poller [candidate] (3.723 ms) : 0, 3723
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (694.293 ms) : 0, 694293
BytebuddyAgent [candidate] (690.374 ms) : 0, 690374
GlobalTracer [baseline] (260.323 ms) : 0, 260323
GlobalTracer [candidate] (259.262 ms) : 0, 259262
IAST [baseline] (24.768 ms) : 0, 24768
IAST [candidate] (24.544 ms) : 0, 24544
AppSec [baseline] (176.181 ms) : 0, 176181
AppSec [candidate] (175.437 ms) : 0, 175437
Debugger [baseline] (67.592 ms) : 0, 67592
Debugger [candidate] (67.555 ms) : 0, 67555
Remote Config [baseline] (695.083 µs) : 0, 695
Remote Config [candidate] (690.095 µs) : 0, 690
Telemetry [baseline] (9.121 ms) : 0, 9121
Telemetry [candidate] (9.23 ms) : 0, 9230
Flare Poller [baseline] (3.879 ms) : 0, 3879
Flare Poller [candidate] (4.122 ms) : 0, 4122
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (802.511 ms) : 0, 802511
BytebuddyAgent [candidate] (793.844 ms) : 0, 793844
GlobalTracer [baseline] (258.815 ms) : 0, 258815
GlobalTracer [candidate] (258.619 ms) : 0, 258619
IAST [baseline] (27.335 ms) : 0, 27335
IAST [candidate] (27.232 ms) : 0, 27232
AppSec [baseline] (35.611 ms) : 0, 35611
AppSec [candidate] (35.442 ms) : 0, 35442
Debugger [baseline] (65.333 ms) : 0, 65333
Debugger [candidate] (65.848 ms) : 0, 65848
Remote Config [baseline] (593.463 µs) : 0, 593
Remote Config [candidate] (550.227 µs) : 0, 550
Telemetry [baseline] (8.392 ms) : 0, 8392
Telemetry [candidate] (8.495 ms) : 0, 8495
Flare Poller [baseline] (3.453 ms) : 0, 3453
Flare Poller [candidate] (3.525 ms) : 0, 3525
section profiling
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (706.217 ms) : 0, 706217
BytebuddyAgent [candidate] (700.737 ms) : 0, 700737
GlobalTracer [baseline] (222.194 ms) : 0, 222194
GlobalTracer [candidate] (220.695 ms) : 0, 220695
AppSec [baseline] (32.295 ms) : 0, 32295
AppSec [candidate] (32.206 ms) : 0, 32206
Debugger [baseline] (68.932 ms) : 0, 68932
Debugger [candidate] (68.457 ms) : 0, 68457
Remote Config [baseline] (645.073 µs) : 0, 645
Remote Config [candidate] (632.127 µs) : 0, 632
Telemetry [baseline] (9.115 ms) : 0, 9115
Telemetry [candidate] (8.965 ms) : 0, 8965
Flare Poller [baseline] (3.823 ms) : 0, 3823
Flare Poller [candidate] (3.793 ms) : 0, 3793
ProfilingAgent [baseline] (97.482 ms) : 0, 97482
ProfilingAgent [candidate] (97.193 ms) : 0, 97193
Profiling [baseline] (98.073 ms) : 0, 98073
Profiling [candidate] (97.775 ms) : 0, 97775
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.079 s) : 0, 1079102
Total [baseline] (8.754 s) : 0, 8753766
Agent [candidate] (1.085 s) : 0, 1084537
Total [candidate] (8.773 s) : 0, 8772835
section iast
Agent [baseline] (1.219 s) : 0, 1219419
Total [baseline] (9.409 s) : 0, 9409387
Agent [candidate] (1.223 s) : 0, 1222869
Total [candidate] (9.411 s) : 0, 9410740
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (648.082 ms) : 0, 648082
BytebuddyAgent [candidate] (648.932 ms) : 0, 648932
GlobalTracer [baseline] (281.316 ms) : 0, 281316
GlobalTracer [candidate] (284.146 ms) : 0, 284146
AppSec [baseline] (32.343 ms) : 0, 32343
AppSec [candidate] (32.899 ms) : 0, 32899
Debugger [baseline] (67.385 ms) : 0, 67385
Debugger [candidate] (68.186 ms) : 0, 68186
Remote Config [baseline] (633.799 µs) : 0, 634
Remote Config [candidate] (630.684 µs) : 0, 631
Telemetry [baseline] (8.895 ms) : 0, 8895
Telemetry [candidate] (9.039 ms) : 0, 9039
Flare Poller [baseline] (3.696 ms) : 0, 3696
Flare Poller [candidate] (3.775 ms) : 0, 3775
section iast
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (788.78 ms) : 0, 788780
BytebuddyAgent [candidate] (791.76 ms) : 0, 791760
GlobalTracer [baseline] (255.058 ms) : 0, 255058
GlobalTracer [candidate] (255.812 ms) : 0, 255812
IAST [baseline] (26.742 ms) : 0, 26742
IAST [candidate] (26.83 ms) : 0, 26830
AppSec [baseline] (33.644 ms) : 0, 33644
AppSec [candidate] (33.561 ms) : 0, 33561
Debugger [baseline] (66.039 ms) : 0, 66039
Debugger [candidate] (65.801 ms) : 0, 65801
Remote Config [baseline] (568.794 µs) : 0, 569
Remote Config [candidate] (543.422 µs) : 0, 543
Telemetry [baseline] (8.421 ms) : 0, 8421
Telemetry [candidate] (8.405 ms) : 0, 8405
Flare Poller [baseline] (3.491 ms) : 0, 3491
Flare Poller [candidate] (3.494 ms) : 0, 3494
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section baseline
no_agent (18.996 ms) : 18799, 19192
. : milestone, 18996,
appsec (18.575 ms) : 18382, 18768
. : milestone, 18575,
code_origins (17.444 ms) : 17268, 17619
. : milestone, 17444,
iast (17.68 ms) : 17507, 17853
. : milestone, 17680,
profiling (19.406 ms) : 19213, 19599
. : milestone, 19406,
tracing (17.481 ms) : 17308, 17655
. : milestone, 17481,
section candidate
no_agent (18.409 ms) : 18220, 18599
. : milestone, 18409,
appsec (18.336 ms) : 18151, 18521
. : milestone, 18336,
code_origins (17.703 ms) : 17528, 17877
. : milestone, 17703,
iast (17.578 ms) : 17407, 17749
. : milestone, 17578,
profiling (19.239 ms) : 19047, 19430
. : milestone, 19239,
tracing (18.686 ms) : 18497, 18874
. : milestone, 18686,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section baseline
no_agent (1.19 ms) : 1178, 1202
. : milestone, 1190,
iast (3.344 ms) : 3296, 3392
. : milestone, 3344,
iast_FULL (5.874 ms) : 5815, 5933
. : milestone, 5874,
iast_GLOBAL (3.635 ms) : 3579, 3692
. : milestone, 3635,
profiling (1.987 ms) : 1970, 2004
. : milestone, 1987,
tracing (1.769 ms) : 1754, 1785
. : milestone, 1769,
section candidate
no_agent (1.196 ms) : 1184, 1207
. : milestone, 1196,
iast (3.184 ms) : 3142, 3226
. : milestone, 3184,
iast_FULL (5.719 ms) : 5661, 5777
. : milestone, 5719,
iast_GLOBAL (3.683 ms) : 3626, 3741
. : milestone, 3683,
profiling (1.906 ms) : 1890, 1922
. : milestone, 1906,
tracing (1.829 ms) : 1813, 1844
. : milestone, 1829,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.727 ms) : 3509, 3946
. : milestone, 3727,
iast (2.22 ms) : 2156, 2285
. : milestone, 2220,
iast_GLOBAL (2.257 ms) : 2192, 2322
. : milestone, 2257,
profiling (2.095 ms) : 2040, 2150
. : milestone, 2095,
tracing (2.051 ms) : 2000, 2102
. : milestone, 2051,
section candidate
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (2.514 ms) : 2460, 2569
. : milestone, 2514,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.065 ms) : 2012, 2117
. : milestone, 2065,
tracing (2.057 ms) : 2006, 2108
. : milestone, 2057,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~5f79e2e819, baseline=1.57.0-SNAPSHOT~66700daef2
dateFormat X
axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
appsec (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
iast (18.12 s) : 18120000, 18120000
. : milestone, 18120000,
iast_GLOBAL (17.771 s) : 17771000, 17771000
. : milestone, 17771000,
profiling (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
tracing (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
section candidate
no_agent (15.575 s) : 15575000, 15575000
. : milestone, 15575000,
appsec (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
iast (18.641 s) : 18641000, 18641000
. : milestone, 18641000,
iast_GLOBAL (17.915 s) : 17915000, 17915000
. : milestone, 17915000,
profiling (14.798 s) : 14798000, 14798000
. : milestone, 14798000,
tracing (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
|
60e96f9 to
5f79e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Enables Spark Plan metadata parsing for all users with Spark instrumentation enabled.
Motivation
This has been tested internally for ~2-3 weeks and seems to be stable. Ship this to all users!
Additional Notes
N/A
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: DJM-974