-
Notifications
You must be signed in to change notification settings - Fork 323
Simplify tasks partitioning UX #10158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d2a0af6 to
12e4fff
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077615
Total [baseline] (10.879 s) : 0, 10878763
Agent [candidate] (1.087 s) : 0, 1086921
Total [candidate] (10.904 s) : 0, 10903517
section appsec
Agent [baseline] (1.264 s) : 0, 1263546
Total [baseline] (11.017 s) : 0, 11016540
Agent [candidate] (1.27 s) : 0, 1270150
Total [candidate] (11.065 s) : 0, 11065097
section iast
Agent [baseline] (1.232 s) : 0, 1231603
Total [baseline] (11.3 s) : 0, 11300125
Agent [candidate] (1.226 s) : 0, 1225986
Total [candidate] (11.127 s) : 0, 11127344
section profiling
Agent [baseline] (1.212 s) : 0, 1212377
Total [baseline] (10.967 s) : 0, 10966626
Agent [candidate] (1.206 s) : 0, 1206272
Total [candidate] (10.935 s) : 0, 10935121
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (646.847 ms) : 0, 646847
BytebuddyAgent [candidate] (652.233 ms) : 0, 652233
GlobalTracer [baseline] (280.789 ms) : 0, 280789
GlobalTracer [candidate] (283.015 ms) : 0, 283015
AppSec [baseline] (32.329 ms) : 0, 32329
AppSec [candidate] (32.654 ms) : 0, 32654
Debugger [baseline] (67.654 ms) : 0, 67654
Debugger [candidate] (68.717 ms) : 0, 68717
Remote Config [baseline] (660.795 µs) : 0, 661
Remote Config [candidate] (651.298 µs) : 0, 651
Telemetry [baseline] (9.056 ms) : 0, 9056
Telemetry [candidate] (9.065 ms) : 0, 9065
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.779 ms) : 0, 3779
section appsec
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (688.944 ms) : 0, 688944
BytebuddyAgent [candidate] (690.887 ms) : 0, 690887
GlobalTracer [baseline] (257.563 ms) : 0, 257563
GlobalTracer [candidate] (260.657 ms) : 0, 260657
AppSec [baseline] (174.016 ms) : 0, 174016
AppSec [candidate] (176.166 ms) : 0, 176166
Debugger [baseline] (68.209 ms) : 0, 68209
Debugger [candidate] (67.202 ms) : 0, 67202
Remote Config [baseline] (722.28 µs) : 0, 722
Remote Config [candidate] (734.68 µs) : 0, 735
Telemetry [baseline] (9.068 ms) : 0, 9068
Telemetry [candidate] (9.092 ms) : 0, 9092
Flare Poller [baseline] (3.906 ms) : 0, 3906
Flare Poller [candidate] (3.965 ms) : 0, 3965
IAST [baseline] (24.509 ms) : 0, 24509
IAST [candidate] (24.773 ms) : 0, 24773
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (796.531 ms) : 0, 796531
BytebuddyAgent [candidate] (794.411 ms) : 0, 794411
GlobalTracer [baseline] (257.508 ms) : 0, 257508
GlobalTracer [candidate] (255.966 ms) : 0, 255966
AppSec [baseline] (35.394 ms) : 0, 35394
AppSec [candidate] (34.363 ms) : 0, 34363
Debugger [baseline] (65.786 ms) : 0, 65786
Debugger [candidate] (65.382 ms) : 0, 65382
Remote Config [baseline] (549.609 µs) : 0, 550
Remote Config [candidate] (536.863 µs) : 0, 537
Telemetry [baseline] (8.551 ms) : 0, 8551
Telemetry [candidate] (8.376 ms) : 0, 8376
Flare Poller [baseline] (3.528 ms) : 0, 3528
Flare Poller [candidate] (3.453 ms) : 0, 3453
IAST [baseline] (26.977 ms) : 0, 26977
IAST [candidate] (26.776 ms) : 0, 26776
section profiling
ProfilingAgent [baseline] (97.339 ms) : 0, 97339
ProfilingAgent [candidate] (97.233 ms) : 0, 97233
crashtracking [baseline] (1.218 ms) : 0, 1218
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (706.319 ms) : 0, 706319
BytebuddyAgent [candidate] (702.881 ms) : 0, 702881
GlobalTracer [baseline] (222.322 ms) : 0, 222322
GlobalTracer [candidate] (221.266 ms) : 0, 221266
AppSec [baseline] (32.596 ms) : 0, 32596
AppSec [candidate] (32.211 ms) : 0, 32211
Debugger [baseline] (68.823 ms) : 0, 68823
Debugger [candidate] (68.148 ms) : 0, 68148
Remote Config [baseline] (643.711 µs) : 0, 644
Remote Config [candidate] (643.697 µs) : 0, 644
Telemetry [baseline] (9.109 ms) : 0, 9109
Telemetry [candidate] (9.091 ms) : 0, 9091
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.786 ms) : 0, 3786
Profiling [baseline] (97.918 ms) : 0, 97918
Profiling [candidate] (97.806 ms) : 0, 97806
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.082 s) : 0, 1081783
Total [baseline] (8.726 s) : 0, 8726083
Agent [candidate] (1.082 s) : 0, 1082272
Total [candidate] (8.763 s) : 0, 8763180
section iast
Agent [baseline] (1.24 s) : 0, 1240281
Total [baseline] (9.443 s) : 0, 9442834
Agent [candidate] (1.228 s) : 0, 1228486
Total [candidate] (9.416 s) : 0, 9415727
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (649.354 ms) : 0, 649354
BytebuddyAgent [candidate] (650.596 ms) : 0, 650596
GlobalTracer [baseline] (282.065 ms) : 0, 282065
GlobalTracer [candidate] (282.171 ms) : 0, 282171
AppSec [baseline] (32.339 ms) : 0, 32339
AppSec [candidate] (32.3 ms) : 0, 32300
Debugger [baseline] (67.834 ms) : 0, 67834
Debugger [candidate] (66.995 ms) : 0, 66995
Remote Config [baseline] (643.302 µs) : 0, 643
Remote Config [candidate] (652.571 µs) : 0, 653
Telemetry [baseline] (9.069 ms) : 0, 9069
Telemetry [candidate] (9.079 ms) : 0, 9079
Flare Poller [baseline] (3.732 ms) : 0, 3732
Flare Poller [candidate] (3.728 ms) : 0, 3728
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (803.972 ms) : 0, 803972
BytebuddyAgent [candidate] (795.581 ms) : 0, 795581
GlobalTracer [baseline] (259.347 ms) : 0, 259347
GlobalTracer [candidate] (256.946 ms) : 0, 256946
IAST [baseline] (27.336 ms) : 0, 27336
IAST [candidate] (27.153 ms) : 0, 27153
AppSec [baseline] (33.855 ms) : 0, 33855
AppSec [candidate] (34.559 ms) : 0, 34559
Debugger [baseline] (66.255 ms) : 0, 66255
Debugger [candidate] (65.115 ms) : 0, 65115
Remote Config [baseline] (554.971 µs) : 0, 555
Remote Config [candidate] (555.264 µs) : 0, 555
Telemetry [baseline] (8.532 ms) : 0, 8532
Telemetry [candidate] (8.451 ms) : 0, 8451
Flare Poller [baseline] (3.522 ms) : 0, 3522
Flare Poller [candidate] (3.531 ms) : 0, 3531
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section baseline
no_agent (19.081 ms) : 18883, 19278
. : milestone, 19081,
appsec (18.864 ms) : 18671, 19057
. : milestone, 18864,
code_origins (17.558 ms) : 17382, 17735
. : milestone, 17558,
iast (17.734 ms) : 17556, 17911
. : milestone, 17734,
profiling (19.178 ms) : 18985, 19370
. : milestone, 19178,
tracing (17.862 ms) : 17683, 18040
. : milestone, 17862,
section candidate
no_agent (17.062 ms) : 16892, 17231
. : milestone, 17062,
appsec (18.682 ms) : 18493, 18871
. : milestone, 18682,
code_origins (17.768 ms) : 17590, 17947
. : milestone, 17768,
iast (17.853 ms) : 17675, 18031
. : milestone, 17853,
profiling (18.902 ms) : 18710, 19094
. : milestone, 18902,
tracing (17.731 ms) : 17553, 17908
. : milestone, 17731,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section baseline
no_agent (1.204 ms) : 1193, 1216
. : milestone, 1204,
iast (3.196 ms) : 3152, 3241
. : milestone, 3196,
iast_FULL (5.848 ms) : 5790, 5906
. : milestone, 5848,
iast_GLOBAL (3.625 ms) : 3562, 3689
. : milestone, 3625,
profiling (1.986 ms) : 1969, 2003
. : milestone, 1986,
tracing (1.83 ms) : 1815, 1846
. : milestone, 1830,
section candidate
no_agent (1.133 ms) : 1122, 1145
. : milestone, 1133,
iast (3.1 ms) : 3057, 3143
. : milestone, 3100,
iast_FULL (5.627 ms) : 5571, 5683
. : milestone, 5627,
iast_GLOBAL (3.468 ms) : 3418, 3518
. : milestone, 3468,
profiling (1.78 ms) : 1765, 1795
. : milestone, 1780,
tracing (1.724 ms) : 1710, 1738
. : milestone, 1724,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section baseline
no_agent (1.486 ms) : 1475, 1498
. : milestone, 1486,
appsec (3.735 ms) : 3515, 3955
. : milestone, 3735,
iast (2.225 ms) : 2160, 2290
. : milestone, 2225,
iast_GLOBAL (2.266 ms) : 2201, 2331
. : milestone, 2266,
profiling (2.081 ms) : 2029, 2134
. : milestone, 2081,
tracing (2.064 ms) : 2012, 2115
. : milestone, 2064,
section candidate
no_agent (1.482 ms) : 1470, 1493
. : milestone, 1482,
appsec (3.672 ms) : 3458, 3887
. : milestone, 3672,
iast (2.232 ms) : 2167, 2296
. : milestone, 2232,
iast_GLOBAL (2.275 ms) : 2210, 2340
. : milestone, 2275,
profiling (2.084 ms) : 2031, 2137
. : milestone, 2084,
tracing (2.056 ms) : 2005, 2108
. : milestone, 2056,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~1bff61693b, baseline=1.57.0-SNAPSHOT~d0b41139cd
dateFormat X
axisFormat %s
section baseline
no_agent (15.619 s) : 15619000, 15619000
. : milestone, 15619000,
appsec (14.974 s) : 14974000, 14974000
. : milestone, 14974000,
iast (18.292 s) : 18292000, 18292000
. : milestone, 18292000,
iast_GLOBAL (17.712 s) : 17712000, 17712000
. : milestone, 17712000,
profiling (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
tracing (14.71 s) : 14710000, 14710000
. : milestone, 14710000,
section candidate
no_agent (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
appsec (14.476 s) : 14476000, 14476000
. : milestone, 14476000,
iast (18.435 s) : 18435000, 18435000
. : milestone, 18435000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
tracing (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
|
| script: | ||
| - export SKIP_BUILDSCAN="true" | ||
| - ./gradlew --version | ||
| - ./gradlew :runMuzzle -PtaskPartitionCount=$NORMALIZED_NODE_TOTAL -PtaskPartition=$NORMALIZED_NODE_INDEX $GRADLE_ARGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some env that now are no more referenced. should they be cleaned up as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes those are cleaned up
9d374ce to
1bff616
Compare
What Does This Do
Instead of passing two property to specify a partition or a slot, this PR allows to pass a fraction as a single property named
slote.g. :This will also enable to reproduce locally, e.g. when a CI job indicates
test_base: [8, 3/4], it can be reproduced easily:test_base->:baseTest,8->-PtestJvm=8,3/4->-Pslot=3/4.Also added some info logging.
The ci config had the flag out of order, total was first.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]