Skip to content

Conversation

@ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Dec 12, 2025

What does this PR do?

This pull-request make the building script compatible with the apple/container which is not a drop-in replacement of docker for macOS user.

Motivation

Having a build script that work with regular docker or container on macOS.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ViBiOh ViBiOh requested a review from a team as a code owner December 12, 2025 16:19
@github-actions github-actions bot added the aws label Dec 12, 2025
@ViBiOh ViBiOh force-pushed the vibioh/apple_container_docker branch from b5acae4 to b2c4734 Compare December 12, 2025 16:20
@ge0Aja ge0Aja self-assigned this Dec 15, 2025
Copy link
Contributor

@ge0Aja ge0Aja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ViBiOh ViBiOh merged commit 319a81c into master Dec 15, 2025
11 checks passed
@ViBiOh ViBiOh deleted the vibioh/apple_container_docker branch December 15, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants