Update Asm Blocked Response #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophe-papazian
approved these changes
Nov 24, 2025
|
Can we enable appsec blocking system tests on this CI before merging it? |
christophe-papazian
approved these changes
Dec 12, 2025
joeyzhao2018
approved these changes
Dec 12, 2025
rithikanarayan
deleted the
rithika.narayan/update-asm-blocked-response
branch
6 tasks
| content = http_utils._get_blocked_template(content_type) | ||
| content = http_utils._get_blocked_template( | ||
| content_type, blocked.get("block_id", "default") | ||
| ) |
Contributor
There was a problem hiding this comment.
This really should have a test. Something to confirm that we're passing the correct values to the _get_blocked_template method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the asm function get_asm_blocked_response to create a Block_config (from ddtrace.appsec._utils) and pass in the block id as the security_response_id argument to the _get_blocked_template function.
Motivation
dd-trace-py recently updated the function signature of ddtrace.internal.utils.http._get_blocked_template to have an additional argument. We need to update the use of this function in datadog_lambda/asm.py.
Testing Guidelines
CI
Additional Notes
Types of Changes
Check all that apply