[DT-2789] Add DAR accept page for Signing Officials#3264
Merged
Conversation
fboulnois
commented
Jan 16, 2026
fboulnois
force-pushed
the
fb-dt-2789-dar-approvals
branch
from
48a66ba to
ab64ec9
Compare
fboulnois
force-pushed
the
fb-dt-2789-dar-approvals
branch
from
069eb11 to
f75a079
Compare
fboulnois
requested review from
kevinmarete and
otchet-broad
and removed request for
a team
Contributor
Author
|
The SonarQube issues are preexisting issues with the components, they require a heavy lift and seem out of scope for this PR. |
| try { | ||
| setIsLoading(true) | ||
| const collectionList = (await Collections.getCollectionSummariesByRoleName(USER_ROLES.signingOfficial)) | ||
| .filter((collection: DarCollectionSummary) => collection.requiresSOApproval === true) |
Contributor
There was a problem hiding this comment.
Probably a follow-up ticket and something for product:
Should we also put closeout DARs that need SO approval in this list? I've added this to the parking lot for Monday.
otchet-broad
approved these changes
Jan 23, 2026
Contributor
otchet-broad
left a comment
otchet-broad
left a comment
There was a problem hiding this comment.
Looks great!
One small suggestion on naming and one question that's probably out of scope for this ticket.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-2789
Summary
Adds the DAR accept page for Signing Officials.
Have you read Terra's Contributing Guide lately? If not, do that first.