pre-commit: autoupdate hooks#117
Open
pre-commit-ci[bot] wants to merge 6981 commits into
Open
Conversation
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
6cf37b9 to
fdb6e4f
Compare
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
fdb6e4f to
86c9798
Compare
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
86c9798 to
9b9293b
Compare
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
9b9293b to
e3fe2ce
Compare
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
The HOBs created by BuildCvHob() will get picked up and processed by MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleProcessLib.c in DXE. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
To avoid errors caused by typos. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Enrolling or removing any signature should require a reset to avoid booting a system with some weird value of PCR-7. The PCR is extended on writes into SecureBoot-related variables (see SecureBootHook() in SecurityPkg/DxeImageVerificationLib) and then right before booting (in TcgDxe or Tcg2Dxe in OnReadyToBoot() handler), meaning that editing SecureBoot configuration and continuing boot process without a reset results in an unexpected value of PCR-7 even if the end result of changes is the same as it would be without any changes. Now reset is required in the following cases as well: * enrolling/deletion of a KEK signature * enrolling/deletion of a DB signature * enrolling/deletion of a DBX signature (one or all of them) * enrolling/deletion of a DBT signature Addition cases are handled in VFR while deletion options are checkboxes generated in C and that's where the flags get set (number of updated places is fewer than number of handled cases because functions are shared by menus). Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
There is an assumption in `IsPciDeviceRejected()` (at least for I/O) that a BAR with all read-write bits set is invalid. However, this is not the case: when a resource is size-aligned down from the top, this may also be the case. This code causes the rejection of the iGPU (and therefore, display) in some cases with the DasharoPayloadPkg, when the coreboot ESOURCE_ALLOCATION_TOP_DOWN config is enabled. It remains to be seen whether this code addresses some other issue. Signed-off-by: Benjamin Doron <benjamin.doron@9elements.com>
This is the only setting that requires edk2-platforms, and only for PcdVTdPolicyPropertyMask. As not all platforms support VTd, fetching edk2-platforms unconditionally isn't necessary. This change creates the possibility to build Dasharo edk2 payload without edk2-platform. Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Resource allocator used by coreboot may produce intertwined prefetchable and non-prefetchable MMIO regions. Since edk2 assumes that there is at most one continuous region of given type, this may create overlaps. This change removes overlapping part of region from PMem, leaving it only in Mem (and similarly for Above4G variants). By doing so, some of memory regions that could otherwise be WC are now UC, but this is safer than doing it the other way around. The regions are not split into smaller ones, as doing so would lead to bigger fragmentation and potentially depletion of MTRRs. Signed-off-by: Krystian Hebel <krystian.hebel@3mdeb.com>
…Services() Prevent debugging on serial port (whether physical or cbmem console) at runtime by not doing anything after boot services are exited. It will stop calling SerialPortWrite if EFI switches to runtime and avoid access to cbmem CONSOLE buffer which is neither marked as runtime code nor data. If serial debugging will be necessary, actually mark coreboot's CONSOLE buffer as runtime data (it's location and size are known). Solves the issue with Xen backtrace on EFI reset system runtime service: Dasharo/dasharo-issues#488 (comment) Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
The CPU throttling used an excessive number of variables. The allowed range of values should be fixed at build, saving it as a NV variable makes no sense. Simplify the logic of the CPU throttling range, gaining a better UX than some error popups. Instead of setting the temperature, set the offset which has a fixed allowed range. Display the current threshold temperatue as grayed out fields instead. Also add PCD to control the default value of the throttling offset. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
… enabled options Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Use disableif, which is more convenient for turning off the options entirely, as it will disable the IFR logic for everything nested under the disableif. Unlike supressif, disableif is evaluated only once. It saves time for the processing and will prevent some undesired behavior from occurring, such as a default value not correctly set for the hidden option and causing an IFR logic to fail in bounds check, etc. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…nabled options Add list of conditions under which the variable should be created. We only want to create variables for options that are enabled in the given project/build. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Use FixedPcdGetBool to emphasize the use of immutable FixedAtBuild PCD. It will also prevent changing the PCD type later and possibly alter the behavior of the menu by other modules if something was to change the PCD type. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
…om UiApp scope Setting the PCDs only in the UiApp scope does not seem not to be propagated to the DasharoModulesPkg libraries when FixedPcdGetBool is used with those PCDs. Move away the PCD settings to the global PCD section in the DSC. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
It prevents booting El torito CDROMs. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Go¿a¿ <filip.golas@3mdeb.com> Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Go¿a¿ <filip.golas@3mdeb.com> Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
Signed-off-by: Filip Gołaś <filip.golas@3mdeb.com>
…he INF file Fix build complaining on missing ParseVBootWorkbuf. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Add PlatformGopPolicy to use external GOP driver Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Use PlatformGopPolicy in place of GraphicsOutputDxe if command line param passed Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
That is loading and processing on-disk capsules during the same boot without relocating the capsules to a dedicated non-volatile storage on ESP or loading them as in-RAM capsules and then rebooting. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
…vs. capsules Limit the scope of the warning to in-RAM capsules when on-disk capsules are enabled. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
a28d997 to
3d57384
Compare
…fix `#undef` When `STORE_VAR` was renamed to `STORE_VAR_IF`, `#undef` wasn't updated. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Mainly update several places to reflect code changes. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This is for upstream, no need to have it send PRs that we won't merge. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This is what upstream uses, no need for it in the fork. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
At this moment it contains: - DrainInput() - DrawGraphicPopUp() Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Unused at this point. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Trace various branches of capsule processing to report how handling of a capsule or its payload went. The report is displayed at the end of the second round of capsule processing or after the first one if it ends with a reboot. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
When flashing during a capsule update, migrate the redundancy-related Slot A - FMAP regions BOOTBLOCK and COREBOOT Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Checking if Boot Guard is enabled and probing the manifests had to be adapted for the new Top Swap region-aware GetCbfs and GetFmap Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Make those added for BootGuard consistent with the rest and get rid of tabulation characters. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
…led: check if KM is valid Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Fixes an issue where entering FUM twice in a row is prevented by the Request variable being the same as the Active variable, being volatile and without runtime write access. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…OPSWAP exists Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
…OTBLOCK and COREBOOT if TS is enabled Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Add a note that the `Keep IOMMU enabled(...)` option is incompatible with Windows, making the OS unable to boot. Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Apply https://edk2.groups.io/g/devel/message/100548 in order to fix SD cards not listing as bootable devices/mountable volumes. Signed-off-by: Filip Lewinski <filip.lewinski@3mdeb.com>
Add a library for interacting with CMOS options exposed by coreboot. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v6.0.0](pre-commit/pre-commit-hooks@v4.4.0...v6.0.0) - [github.com/talos-systems/conform: v0.1.0-alpha.27 → v0.1.0-alpha.31](siderolabs/conform@v0.1.0-alpha.27...v0.1.0-alpha.31) - [github.com/codespell-project/codespell: v2.2.5 → v2.4.2](codespell-project/codespell@v2.2.5...v2.4.2)
pre-commit-ci
Bot
force-pushed
the
pre-commit-ci-update-config
branch
from
3d57384 to
c5dbf42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: