scripts/entrypoint.sh: Fix ioncorrect variable name#6
Conversation
To set the GROUP_ID for the coreboot user one has to pass two variables to docker environment: GROUP and GROUP_ID. Most likely it was a copy-pasta error, which can be fixed by using GROUP_ID in the IF condition. Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
|
@miczyg1 I think it may already be in the main thanks to merging my changes, but just let you know there is merge conflict here and we probably could merge it or close. |
|
I see you are creating a user coreboot here: https://github.com/Dasharo/dasharo-sdk/blob/main/Dockerfile#L149 But I am not sure if it will get the same ID and group as the user on the host. So the changes may still actually be valid. I have to think how I can test it. Probably creating a second user on a machine and see if the container invoked by that user does not have permission problems. |
|
Good point; I don't know what your initial motivation was, nor how you planned to validate it. Take your time. My question was triggered by bounty and community questions related to rootless Docker. |
3 participants
To set the GROUP_ID for the coreboot user one has to pass two variables to docker environment: GROUP and GROUP_ID. Most likely it was a copy-pasta error, which can be fixed by using GROUP_ID in the IF condition.