Skip to content

Protectli V1xxx: Adjust NVMe link width to x2 #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkopec wants to merge 5 commits into
base: dasharo
Choose a base branch
from
Open

Protectli V1xxx: Adjust NVMe link width to x2 #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1371f05
Revert "mb/protectli/vault_jsl/override_v1610.cb: Move NVMe disk to R…
mkopec May 11, 2026
9989ff4
Revert "mb/protectli/vault_jsl/override_v14xx.cb: Move NVMe disk to R…
mkopec May 11, 2026
ec9ad86
Revert "mb/protectli/vault_jsl/override_v12xx.cb: Move NVMe disk to R…
mkopec May 11, 2026
3ba5f2a
src/mainboard/protectli/vault_jsl/override_v1*: adjust for x2 SSD bif…
mkopec May 12, 2026
5e4b1fc
3rdparty/dasharo-blobs: Bump for vault_jsl x2 NVMe fix
mkopec May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/dasharo-blobs
Open in desktop
Submodule dasharo-blobs updated 7 files
+9 −0 protectli/vault_jsl/README.md
+3 −3 protectli/vault_jsl/SHA256SUMS
+0 −16 protectli/vault_jsl/SHA256SUMS.asc
+13 −13 protectli/vault_jsl/SHA256SUMS.sig
+ − protectli/vault_jsl/V1210/descriptor.bin
+ − protectli/vault_jsl/V1410/descriptor.bin
+ − protectli/vault_jsl/V1610/descriptor.bin
3 changes: 1 addition & 2 deletions src/mainboard/protectli/vault_jsl/mainboard.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,7 @@ void mainboard_silicon_init_params(FSP_S_CONFIG *params)
* Disable ASPM L1 for SSD slot, as it does not work reliably with Samsung
* NVMe SSDs.
*/
params->PcieRpAspm[CONFIG(BOARD_PROTECTLI_V1210) || CONFIG(BOARD_PROTECTLI_V1211) ? 0 : 2]
= FSP_PCH_PCIE_ASPM_L0S;
params->PcieRpAspm[0] = FSP_PCH_PCIE_ASPM_L0S;

/*
* HWP is too aggressive in power savings and does not let using full
Expand Down
7 changes: 2 additions & 5 deletions src/mainboard/protectli/vault_jsl/override_v12xx.cb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
chip soc/intel/jasperlake
device domain 0 on
device pci 1c.0 off end # PCI Express Root Port 1
device pci 1c.1 off end # PCI Express Root Port 2
device pci 1c.2 off end # PCI Express Root Port 3
device pci 1c.3 on # PCI Express Root Port 4
device pci 1c.0 on # PCI Express Root Port 1 (NVMe)
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
"M.2/M 2280 (NVMe)" "SlotDataBusWidth2X"
end
Expand All @@ -17,6 +14,6 @@ chip soc/intel/jasperlake
device pci 1c.6 on # PCI Express Root Port 7 (LAN2)
smbios_dev_info 2
end
device pci 1c.7 off end # PCI Express Root Port 8
device pci 1c.7 off end # PCI Express Root Port 8
end
end
13 changes: 6 additions & 7 deletions src/mainboard/protectli/vault_jsl/override_v1410.cb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
chip soc/intel/jasperlake
device domain 0 on
device pci 1c.0 on # PCI Express Root Port 1 (LAN1)
smbios_dev_info 1
device pci 1c.0 on # PCI Express Root Port 1
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
"M.2/M 2280 (NVMe)" "SlotDataBusWidth1X"
end
device pci 1c.1 on # PCI Express Root Port 2 (LAN2)
device pci 1c.2 on # PCI Express Root Port 3 (LAN2)
smbios_dev_info 2
end
device pci 1c.2 off end # PCI Express Root Port 3
device pci 1c.3 on # PCI Express Root Port 4
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
"M.2/M 2280 (NVMe)" "SlotDataBusWidth1X"
device pci 1c.3 on # PCI Express Root Port 4 (LAN1)
smbios_dev_info 1
end
device pci 1c.4 on # PCI Express Root Port 5
smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther"
Expand Down
8 changes: 3 additions & 5 deletions src/mainboard/protectli/vault_jsl/override_v1610.cb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
chip soc/intel/jasperlake
device domain 0 on
# ASMedia PCIe switch with x2 link to 4x1 ports (3 LANs and WiFi)
device pci 1c.0 on end # PCI Express Root Port 1
device pci 1c.1 off end # PCI Express Root Port 2
device pci 1c.2 off end # PCI Express Root Port 3
device pci 1c.3 on # PCI Express Root Port 4
device pci 1c.0 on # PCI Express Root Port 1
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
"M.2/M 2280 (NVMe)" "SlotDataBusWidth2X"
end
# ASMedia PCIe switch with x2 link to 4x1 ports (3 LANs and WiFi)
device pci 1c.2 on end # PCI Express Root Port 3
device pci 1c.4 on # PCI Express Root Port 5
smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther"
"M.2/E 2230 (WIFI)" "SlotDataBusWidth1X"
Expand Down
Loading