Skip to content

Revert transformers path#472

Open
Irozuku wants to merge 3 commits intodevelopfrom
revert/transformers-path
Open

Revert transformers path#472
Irozuku wants to merge 3 commits intodevelopfrom
revert/transformers-path

Conversation

@Irozuku
Copy link
Collaborator

@Irozuku Irozuku commented Mar 9, 2026

Summary

Reverts a previous pull request that removed temporary checkpoint handling during model training. This restores the behavior where models can use a dedicated temporary directory for Hugging Face training checkpoints and ensures the directory exists during the build process.


Type of Change

Check all that apply like this [x]:

  • Backend change
  • Frontend change
  • CI / Workflow change
  • Build / Packaging change
  • Bug fix
  • Documentation

Changes (by file)

  • .github/workflows/build.yml: Restores creation and inclusion of the DashAI/back/user_models/temp_checkpoints directory in PyInstaller build steps for all platforms.
  • DashAI/back/models/.../distilbert_model.py: Restores the use of a temporary checkpoint directory for the Hugging Face Trainer and cleanup of the directory after training.
  • DashAI/back/models/.../opus_mt_en_es_transformer.py: Reintroduces the temporary checkpoint directory for training and removes it after training completes.

Testing (optional)

  • Verify that the build workflows correctly create and package the temp_checkpoints directory.
  • Confirm that model training runs successfully and that temporary checkpoints are cleaned up after training.

Notes (optional)

This PR reverts the removal of temporary checkpoint handling, restoring support for models that require temporary storage during training while preventing leftover checkpoint files.

@Irozuku Irozuku added the back Backend work label Mar 9, 2026
@Irozuku Irozuku changed the title Revert/transformers path Revert transformers path Mar 9, 2026
@cristian-tamblay
Copy link
Member

I dont know if there's a way to parametrize this so windows+mac executables use the same flags (or at least some), because im sure we will fail adding these to both of them in the future

Copy link
Member

@cristian-tamblay cristian-tamblay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts and maybe try to parametrize flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

back Backend work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants