Open
Conversation
cristian-tamblay
approved these changes
Mar 10, 2026
Member
|
I dont know if there's a way to parametrize this so windows+mac executables use the same flags (or at least some), because im sure we will fail adding these to both of them in the future |
cristian-tamblay
requested changes
Mar 10, 2026
Member
cristian-tamblay
left a comment
There was a problem hiding this comment.
Fix conflicts and maybe try to parametrize flags?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts a previous pull request that removed temporary checkpoint handling during model training. This restores the behavior where models can use a dedicated temporary directory for Hugging Face training checkpoints and ensures the directory exists during the build process.
Type of Change
Check all that apply like this [x]:
Changes (by file)
.github/workflows/build.yml: Restores creation and inclusion of theDashAI/back/user_models/temp_checkpointsdirectory in PyInstaller build steps for all platforms.DashAI/back/models/.../distilbert_model.py: Restores the use of a temporary checkpoint directory for the Hugging FaceTrainerand cleanup of the directory after training.DashAI/back/models/.../opus_mt_en_es_transformer.py: Reintroduces the temporary checkpoint directory for training and removes it after training completes.Testing (optional)
temp_checkpointsdirectory.Notes (optional)
This PR reverts the removal of temporary checkpoint handling, restoring support for models that require temporary storage during training while preventing leftover checkpoint files.