Fix live metrics change view and splits plots#469
Merged
cristian-tamblay merged 2 commits intodevelopfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LiveMetricsChart React component to reduce unnecessary recalculation during renders and to allow the metrics WebSocket to connect to a configurable backend base URL (via REACT_APP_API_URL).
Changes:
- Memoizes metric filtering and chart data preparation with
useMemoto avoid recomputing on unrelated renders. - Refactors WebSocket URL construction to derive the WS base from
REACT_APP_API_URLinstead ofwindow.location.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristian-tamblay
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request optimizes the
LiveMetricsChartcomponent by improving how metric data is filtered and prepared for charting, and by making the WebSocket connection more configurable. The main changes involve usinguseMemofor performance, and updating the WebSocket URL construction to support custom API endpoints.Performance improvements:
useMemo, ensuring these operations are only recalculated when their dependencies change, which improves rendering efficiency. [1] [2] [3]Configuration and maintainability:
REACT_APP_API_URLenvironment variable, allowing the frontend to connect to a custom backend endpoint instead of always using the current window location.