Change mtexinfo_s vecx from float to double to fix lightmap issues#233
Open
hemebond wants to merge 4 commits intoDarkPlacesEngine:masterfrom
Open
Change mtexinfo_s vecx from float to double to fix lightmap issues#233hemebond wants to merge 4 commits intoDarkPlacesEngine:masterfrom
hemebond wants to merge 4 commits intoDarkPlacesEngine:masterfrom
Conversation
Contributor
|
This doesn't feel correct. DotProduct is a macro that makes no assumption of the datatype. You'd want to cast to double in the original DotProduct invocation. So we shouldn't need a double variant. But this smells like an internal double to float downcasting bug and casting feels like a hack without further investigation into why the lightmaps suck. |
Contributor
Author
|
Very good point. I'm still testing, but it looks like I can change |
hemebond
changed the title
|
@hemebond Updates? LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes mtexinfo_s vecs property from float to double so that lightmaps are aligned correctly. Fixes #232.