Fix Rock Candy for Connector #804
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copy-paste commit to 20.1 version, adding missing BC support in commit eed3ed0
vgskye
reviewed
Jan 16, 2026
src/main/java/de/dafuqs/spectrum/mixin/EntityApplyFluidsMixin.java
Outdated
Show resolved
Hide resolved
Updated comment to clarify isSubmergedIn being commented out it was replaced and it was only used in one file. I rather leave it up to someone else to decide whether to fully delete this or not
Owner
When viewing your github fork, there is an option "sync fork". Once the changes have been synced to your repository, you can "update project" in IDEA to pull those changes to your local project at your PC. There are other options, but that's the most straightforward one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was caused by mixin not doing well with connector transmog; this fix redoes the method to check for it while still allowing for the same end-goal and handling to be accounted for
commented out submersion check, it was the only one using it; remove if you think its nessisary to purge
Implitmented Connector-fiendly check, taking advantage of fluid block height being a thing. This should work the same as before while preventing situations like it being on a fence from causing problems (Thanks @800020h for pointing it out)
might not be the most performant, but I dont see it as a problem if its not ticking constantly; any further impovements made should be checked to make sure it works with connector, otherwise this entire thing was pointless
Sidenote: Give me a rundown how to sync stuff with changes, I had to wipe my workspace becasue I had old commits that were already pushed, AUGH