Skip to content

Dark Mode#2290

Open
poisonednumber wants to merge 1 commit into
DSheirer:masterfrom
poisonednumber:dark-mode-pr-clean
Open

Dark Mode#2290
poisonednumber wants to merge 1 commit into
DSheirer:masterfrom
poisonednumber:dark-mode-pr-clean

Conversation

@poisonednumber

@poisonednumber poisonednumber commented Nov 1, 2025

Copy link
Copy Markdown

99% Ai slop...

  • Add ColorThemePreference to store and manage dark mode setting
  • Auto-detect Windows system theme on first launch
  • Add dark mode toggle in preferences with modern UI
  • Apply dark theme to all Swing components (menus, buttons, text fields, etc.)
  • Apply dark theme to all JavaFX components via CSS
  • Improve text readability in broadcast status panel
  • Style all tuner editor controls (RTL, SDRplay, etc.)
  • Style map controls and channel spectrum panel
  • Style history management sliders
  • Style channel metadata and detail panels
  • Respect user preference throughout entire application

…tection

- Add ColorThemePreference to store and manage dark mode setting
- Auto-detect Windows system theme on first launch
- Add dark mode toggle in preferences with modern UI
- Apply dark theme to all Swing components (menus, buttons, text fields, etc.)
- Apply dark theme to all JavaFX components via CSS
- Improve text readability in broadcast status panel
- Style all tuner editor controls (RTL, SDRplay, etc.)
- Style map controls and channel spectrum panel
- Style history management sliders
- Style channel metadata and detail panels
- Respect user preference throughout entire application
@poisonednumber poisonednumber changed the title 99% Ai slop... Dark Mode Nov 1, 2025
@poisonednumber

Copy link
Copy Markdown
Author
sdrtrunk.mp4

@fourohthree

Copy link
Copy Markdown

@poisonednumber I tried this PR out locally, merging your PR with master (Aug 4) on my Mac (Sequoia). While it does make most of the SDRTrunk UI "Dark Mode", at least on Mac the top menubar is not darkened, and more problematically, various sub-menus within the UI have dark background but black text, so are unreadable. While the AI-created code works, UX tweaks like this really need a human's touch.

@fourohthree

fourohthree commented Nov 17, 2025

Copy link
Copy Markdown

Here are screenshots of SDRTrunk 1.6.2-beta1 (master dated 2025-08-04) with your Dark Mode patch applied, but not enabled (first shot) and enabled (second). I'm not experienced with Java coding, but could take a shot at fixing the issues mentioned (tabs within various sub-windows are black text on black background). But if OP can spot what's going on from the screenshots, maybe he can fix faster.

With Dark Mode patch (#2290), but not Enabled (control):
Screenshot 2025-11-17 at 11 41 17 AM

With Dark Mode patch (#2290), Enabled and after restart:
Screenshot 2025-11-17 at 11 44 12 AM

@davidflypei

Copy link
Copy Markdown

at least on Mac the top menubar is not darkened,

If I'm not mistaken, the toolbar on macOS is controlled by the system, not the application, for some reason. I've heard many people complain about Macs having a light toolbar with many (if not all) applications that support a darkmode that isn't set by the system's theme.

@fourohthree

fourohthree commented May 23, 2026

Copy link
Copy Markdown

at least on Mac the top menubar is not darkened,

If I'm not mistaken, the toolbar on macOS is controlled by the system, not the application, for some reason. I've heard many people complain about Macs having a light toolbar with many (if not all) applications that support a darkmode that isn't set by the system's theme.

I had given up on this, but a later-submitted Dark Mode PR (#2411) managed to style the toolbar. So I think it's just this PR that has the issue, along with the hard to read tabs (also fixed in #2411, worth a look).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants