Conversation
…_marking and start finction set_legal_authority.
…ate documentation accordingly.
…or use in cli messaging.
… from github.com/doi-nps in Remotes.
…while unit testing.
fix bug in set_permissions when force = TRUE
…sions, deprecated cui functions and ner version 1.3.0
…_code and set_cui_marking
aserrantes
self-requested a review
October 1, 2026 20:22
aserrantes
reviewed
Oct 1, 2026
| <div class="ref-description section level2"> | ||
| <p><code>set_cui_code()</code> adds Controlled Unclassified Information (CUI) dissemination codes to EML metadata. These codes determine who can or cannot have access to the data. Unless you have a specific mandate to restrict data, all data should be available to the public. if the CUI dissemination code is PUBLIC, the CUI marking should also be PUBLIC (<code>see set_cui_marking()</code>) and the license should be set to CC0 or public domain (see <code><a href="set_int_rights.html">set_int_rights()</a></code>). If your data contains CUI and you need to set the CUI dissemination code to anything other than PUBLIC, please be prepared to provide a legal justification in the form of the appropriate CUI marking (see <code><a href="set_cui_marking.html">set_cui_marking()</a></code>).</p> | ||
| <p><a href="https://lifecycle.r-lib.org/articles/stages.html#deprecated" class="external-link"><img src="figures/lifecycle-deprecated.svg" alt="[Deprecated]"></a> | ||
| <code>set_cui_code()</code> adds Controlled Unclassified Information (CUI) dissemination codes to EML metadata. These codes determine who can or cannot have access to the data. Unless you have a specific mandate to restrict data, all data should be available to the public. if the CUI dissemination code is PUBLIC, the CUI marking should also be PUBLIC (<code>see set_cui_marking()</code>) and the license should be set to CC0 or public domain (see <code><a href="set_int_rights.html">set_int_rights()</a></code>). If your data contains CUI and you need to set the CUI dissemination code to anything other than PUBLIC, please be prepared to provide a legal justification in the form of the appropriate CUI marking (see <code><a href="set_cui_marking.html">set_cui_marking()</a></code>).</p> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <code>set_cui_code()</code> adds Controlled Unclassified Information (CUI) dissemination codes to EML metadata. These codes determine who can or cannot have access to the data. Unless you have a specific mandate to restrict data, all data should be available to the public. if the CUI dissemination code is PUBLIC, the CUI marking should also be PUBLIC (<code>see set_cui_marking()</code>) and the license should be set to CC0 or public domain (see <code><a href="set_int_rights.html">set_int_rights()</a></code>). If your data contains CUI and you need to set the CUI dissemination code to anything other than PUBLIC, please be prepared to provide a legal justification in the form of the appropriate CUI marking (see <code><a href="set_cui_marking.html">set_cui_marking()</a></code>).</p> | |
| <code>set_cui_code()</code> adds Controlled Unclassified Information (CUI) dissemination codes to EML metadata. These codes determine who can or cannot have access to the data. Unless you have a specific mandate to restrict data, all data should be available to the public. If the CUI dissemination code is PUBLIC, the CUI marking should also be PUBLIC (<code>see set_cui_marking()</code>) and the license should be set to CC0 or public domain (see <code><a href="set_int_rights.html">set_int_rights()</a></code>). If your data contains CUI and you need to set the CUI dissemination code to anything other than PUBLIC, please be prepared to provide a legal justification in the form of the appropriate CUI marking (see <code><a href="set_cui_marking.html">set_cui_marking()</a></code>).</p> |
aserrantes
reviewed
Oct 1, 2026
| #' | ||
| #' @description `r lifecycle::badge("experimental")` | ||
| #' `r lifecycle::badge("deprecated")` | ||
| #' The Controlled Unclassified Information (CUI) marking is different from the CUI dissemination code. The CUI dissemination code (set `set_cui_code()`) sets who can have access to the data package. The CUI marking set by `set_cui_marking()` specifies the reason (if any) that the data are being restricted. |
Collaborator
There was a problem hiding this comment.
Should set_cui_code() here be updated to set_permissions()?
aserrantes
reviewed
Oct 1, 2026
|
|
||
| If you choose INTERNAL or RESTRICTED you must also supply a contact email address for people who want to request access (we suggest a group email rather than in individual person's email due to frequent personnel turnover) and a specific person's name who is responsible for making the decision to restrict the file downloads. | ||
|
|
||
| ```{r dessemination permissions, eval = FALSE} |
Collaborator
There was a problem hiding this comment.
Why is eval set to FALSE?
aserrantes
approved these changes
Oct 2, 2026
aserrantes
left a comment
aserrantes
left a comment
Collaborator
There was a problem hiding this comment.
Left a few comments, nothing critical. Looks good, works as intended and creates schema valid metadata objects. Setting force = TRUE for both set_permissions and set_int_rights works as well.
Friendly reminder to update DPchecker! The new permissions cause checks to fail in its current form.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a larger and more sprawling pull request. The main body consists of updating how CUI are handled to better correspond with upcoming DataStore changes in release 4.4 (scheduled October 2026).
The access elements now contain general information about permissions. These are not used by DataStore but are intended to give users a quick way to assess permissions.
Permissions are actually held in additionalMetadata and give a lot more specific information now than just "PUBLIC" vs. "RESTRICTED"
There are several bug fixes to other functions, primarily when the force parameter is set to TRUE. It seems this little-used option was not thoroughly tested previously.
updated unit tests.