NAMECHEAP: Fix paginate zone listing to work with more than 20 items#4330
Merged
TomOnTime merged 1 commit intoMay 26, 2026
Merged
Conversation
Fetch all the pages from Namecheap when listing zones so get-zones and zone existence checks do not miss domains beyond the default first page of 20 results. Add regression test covering multi-page domains.getList responses. Assisted-by: OpenCode gpt-5.4 via OpenCode
TomOnTime
approved these changes
May 25, 2026
Collaborator
|
Thanks for fixing that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a fix for the issue #3824. If the user has more than 20 domains at Namecheap then dnscontrol only gets the first 20. This patch performs paging such that all the domains can be retrieved.
Assisted-by: OpenCode gpt-5.4 via OpenCode
Fixes: #3824