REFACTOR: diff2 should use .ComparableV3 nothing else#4313
Open
TomOnTime wants to merge 47 commits into
Open
Conversation
CC @tresni @allixsenos @jzhang-sre # Issue Some tests fail because they use features that are not available in the "free tier" account we use for testing. # Resolution Reduce the tests to avoid them. The following features will no longer be regularly tested: * CNAME flattening * Tags * "Single redirects" that use the "Matches" subcommand NOTE: Would you like these features to be tested regularly? We'd gladly accept the donation to enable us to buy a "business plan"-level account. (Cloudflare, if you're listening, we'd love a partnership!)
# Issue Bug: #3804 **Describe the bug** When using `HTTPS("…", 1, ".", "alpn=h3 … ech=IGNORE")`, but ech has not yet been set by the owner, then dnscontrol keeps saying it needs to change it … by adding a space that isn't there every run… **To Reproduce** 1. Create a HTTPS record with [`ech=IGNORE`](https://docs.dnscontrol.org/language-reference/domain-modifiers/https) - `+ CREATE ccccc.example.com HTTPS 1 . alpn="h3" ttl=1` 3. run dnscontrol again - `± MODIFY ccccc.example.com HTTPS (1 . alpn="h3" ttl=1) -> (1 . alpn="h3" ttl=1) id=X` 5. Observe changes, every, run… - `± MODIFY ccccc.example.com HTTPS (1 . alpn="h3" ttl=1) -> (1 . alpn="h3" ttl=1) id=X` **Expected behavior** 1. `+ CREATE ccccc.example.com HTTPS 1 . alpn="h3" ttl=1` - observe no double space between value and ttl 2. re-run - observe no change to record **DNS Provider** - Cloudflare **Additional context** The ECH field needs to be managed by whoever manages the certs (probably the webserver), and when making these records but before first use means it doesn't have a value. Note that this issue was missed in testing because [ech has a value](https://github.com/StackExchange/dnscontrol/blob/6ef064877859f3dbc096112c8896160af9e91e3f/integrationTest/integration_test.go#L296) there… # Resolution Remove the quotes in that one situation.
# Issue
HEDNS fails the `testgroup("Ech")`, test.
# Resolution
Skip this test for now. Bug
#4328 opened to track
this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We're migrating RecordConfig V3, which uses dnsv2.
Resolution