Skip to content

Conversation

@Stellatsuu
Copy link
Contributor

@Stellatsuu Stellatsuu commented Jan 21, 2026

Closes: #622

Changes:

  • added a strEnum EntryPointGroups in /diracx-core/.../extensions.py to avoid hardcoded strings and spelling mistakes

Questions:

Answer: #701 contains the doc and isn't merged yet

  • does places where extension = diracx be replaced by EntryPointGroups.CORE? e.g:
# DiracX will always be there so force it to be the lowest priority
return sorted(extensions, key=lambda x: x == "diracx")
--> return sorted(extensions, key=lambda x: x == EntryPointGroups.CORE)
if installed_extension not in [None, "diracx"]: ...
--> if installed_extension not in [None, EntryPointGroups.CORE]: ...
cls.client_modules = ("diracx.client", f"{installed_extension}.client")
--> cls.client_modules = (f"{EntryPointGroups.CORE}.client", f"{installed_extension}.client")

Answer: we don't touch extensions

@Stellatsuu Stellatsuu marked this pull request as draft January 21, 2026 22:13
@aldbr aldbr marked this pull request as ready for review January 22, 2026 08:47
@aldbr aldbr merged commit 19bfadc into DIRACGrid:main Jan 22, 2026
27 checks passed
@Stellatsuu Stellatsuu deleted the refactor/strEnum-Entrypoints branch January 22, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create an StrEnum with the list of known entrypoint names

2 participants