Chore: following suggestions from repo-review #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overview
Show files changed (5 files in total): 📝 5 modified | ➕ 0 added | ➖ 0 deleted
|
fstagni
force-pushed
the
repo_review
branch
6 times, most recently
from
bca2a21 to
91b4c54
Compare
aldbr
reviewed
Jan 22, 2026
fstagni
force-pushed
the
repo_review
branch
2 times, most recently
from
04daf33 to
0c2e006
Compare
aldbr
approved these changes
Jan 23, 2026
chaen
reviewed
Jan 23, 2026
| MyDBClass = BaseOSDB.available_implementations(db_name)[0] | ||
| db = MyDBClass(conn_params) | ||
| await db.init() |
Contributor
There was a problem hiding this comment.
I don't think we have an init() method anywhere ? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://learn.scientific-python.org/development/guides/repo-review/?repo=DIRACGrid%2Fdiracx&ref=main&refType=branch