Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a responsive campaign hero image to the CreditLines page with proper
srcSetandsizesattributes, so mobile devices download only the image resolution they need instead of desktop-sized assets.Closes #848
Changes
src/pages/CreditLines.tsxsrcSetcontaining 3 width candidates (480w, 768w, 1200w)sizesattribute for responsive breakpoint-aware image selectionalttext androle="img"containersrc/pages/CreditLines.css.cl-hero-imagecontainer styles (border-radius, overflow, background).cl-hero-imgresponsive image styles (100% width, auto height, max-height 240px)src/pages/__tests__/CreditLines.responsive.test.tsxsrcsetattribute with 480w, 768w, 1200w candidatessizesattribute with100vwand60vwbreakpointssrcattributeAcceptance Criteria