Use VType display for formatting data browser cursor values#3695
Open
DenSinH wants to merge 2 commits intoControlSystemStudio:masterfrom
Open
Use VType display for formatting data browser cursor values#3695DenSinH wants to merge 2 commits intoControlSystemStudio:masterfrom
DenSinH wants to merge 2 commits intoControlSystemStudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use VType display for formatting data browser cursor marker values. Previously, they were formatted using the formatting specified by the trace (which seemed to be obtained automatically, and depends on the axis labels, which can also not be configured manually it seems). I changed this to where this can be implemented in the
PlotDataItemimplementation. The default one is the same as the one that was implemented before, and I specified it for thePlotSampleclass, where it uses theFormatOptionHandlerwith theDEFAULTformat to format the VType from the selected sample. This makes it so that the value formatted in the cursor marker and the value in the Traces table are all formatted using the VType's format, which is more consistent with the rest of the UI.I am however not sure if I missed some configurable option, or if other sites possibly depend on the "old" formatting.
Checklist
Testing:
Documentation: