Add --base-url flag for connector testability#16
Add --base-url flag for connector testability#16robert-chiniquy wants to merge 4 commits intomainfrom
Conversation
This change adds a --base-url CLI flag to allow overriding the default API endpoint for testing purposes. When provided, the connector will use this URL instead of the hardcoded production API URL. This is part of the Connector Testability initiative to enable mock server testing without modifying connector code. Files changed: cmd/baton-zoom/config.go,cmd/baton-zoom/main.go,pkg/connector/connector.go,pkg/zoom/client.go
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
russellhaering
left a comment
There was a problem hiding this comment.
LGTM — clean base-url override, all URL references properly updated.
base-url is a dev/testing concern, not user-facing configuration. Mark it WithHidden(true) so it doesn't appear in the hosted UI. Good feedback from Geoff: ConductorOne/baton-trayai#63 (comment)
|
Claude finished @robert-chiniquy's task in 1m 13s —— View job PR Review: Add --base-url flag for connector testability
Verdict: Looks good — clean, minimal change that follows the established pattern for base-url overrides. Two reviewers have already approved. I have a few observations: What works well
Observation: Auth URL not overridable
This is fine for the current scope — tests can pre-generate a token and skip the auth call, or a mock server can be set up on a separate port for auth. Just noting it for awareness in case future test setups hit this. Nit: Naming inconsistency (non-blocking)The old constant was Overall: LGTM — this is a straightforward, well-scoped change that enables mock server testing without affecting production behavior. |
Summary
Adds the
--base-urlCLI flag to enable overriding the default API endpoint for testing purposes.Changes
BaseURLFieldto configuration--base-urlis provided, it takes precedence over the default API URLFiles Modified
Testing
The connector can now be tested against mock servers:
Related
Part of the Connector Testability initiative.