Skip to content

Add --base-url flag for connector testability #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robert-chiniquy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add --base-url flag for connector testability #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/config/conf.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,20 @@ var (
field.WithRequired(false),
)

BaseURLField = field.StringField(
"base-url",
field.WithDescription("Override the Temporal Cloud API URL (for testing)"),
field.WithHidden(true),
field.WithExportTarget(field.ExportTargetCLIOnly),
)

// ConfigurationFields defines the external configuration required for the
// connector to run.
ConfigurationFields = []field.SchemaField{
APIKeyField,
AllowInsecureField,
DefaultAccountRoleField,
BaseURLField,
}

// FieldRelationships defines relationships between the fields listed in
Expand Down
3 changes: 3 additions & 0 deletions pkg/connector/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ func (d *Connector) Validate(ctx context.Context) (annotations.Annotations, erro
// New returns a new instance of the connector.
func New(ctx context.Context, tc *cfg.TemporalCloud, opts *cli.ConnectorOpts) (connectorbuilder.ConnectorBuilderV2, []connectorbuilder.Opt, error) {
var clientOpts []client.Opt
if tc.BaseUrl != "" {
clientOpts = append(clientOpts, client.WithAPIAddress(tc.BaseUrl))
}
if tc.AllowInsecure {
clientOpts = append(clientOpts, client.AllowInsecure())
}
Expand Down
Loading