Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #20

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#20
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-newrelic:latest; container images are now published to public.ecr.aws/conductorone/baton-newrelic:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-newrelic:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread README.md
```
docker run --rm -v $(pwd):/out -e BATON_APIKEY=apikey ghcr.io/conductorone/baton-newrelic:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out -e BATON_APIKEY=apikey public.ecr.aws/conductorone/baton-newrelic:latest -f "/out/sync.c1z"
docker run --rm -v $(pwd):/out ghcr.io/conductorone/baton:latest -f "/out/sync.c1z" resources

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: The adjacent baton CLI line still points at ghcr.io/conductorone/baton:latest. If the premise of this PR is that ghcr.io/conductorone/* is deprecated in favor of public.ecr.aws/conductorone/*, this line is stale for the same reason, and leaving one of the two lines in the same code block on the old registry is confusing for readers copy-pasting both commands. Intentionally out of scope per the PR description, so non-blocking — but worth confirming the CLI image is published to ECR and updating it here too.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base c3fc9d651482.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness: it is a single-line documentation change in README.md swapping this connector's image reference from ghcr.io/conductorone/baton-newrelic:latest to public.ecr.aws/conductorone/baton-newrelic:latest. No Go source, go.mod/go.sum, config, or provisioning code changed, so no connector-implementation, dependency, or breaking-change criteria apply; docs/connector.mdx already references the ECR image and is consistent with this change. One non-blocking documentation-consistency suggestion on the adjacent, intentionally-out-of-scope baton CLI line.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:30 — the adjacent baton CLI command still uses ghcr.io/conductorone/baton:latest, the same registry this PR treats as deprecated; out of scope per the PR description, but leaves the two commands in one code block inconsistent.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 30: The docker code block now mixes two registries. Line 29 was updated to
  `public.ecr.aws/conductorone/baton-newrelic:latest`, but line 30 still runs the baton CLI
  from `ghcr.io/conductorone/baton:latest` — the same `ghcr.io/conductorone` registry this PR
  treats as deprecated. Confirm the baton CLI image is published to
  `public.ecr.aws/conductorone/baton`, and if so update line 30 to
  `docker run --rm -v $(pwd):/out public.ecr.aws/conductorone/baton:latest -f "/out/sync.c1z" resources`
  so both commands in the block use the same registry. If the CLI image is deliberately still
  on ghcr.io, leave it as-is.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant