Skip to content

docs: update admin nav path and Add connector flow - #155

Merged
mindymo merged 1 commit into
mainfrom
docs/nav-and-create-connector-drawer
Sep 10, 2026
Merged

docs: update admin nav path and Add connector flow#155
mindymo merged 1 commit into
mainfrom
docs/nav-and-create-connector-drawer

Conversation

@mindymo

@mindymo mindymo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Two upstream product changes affect this connector's docs:

  • Admin nav reorg (ductone/c1#24648): the sidebar path is now Apps > Connectors, replacing Integrations > Connectors.
  • New Add connector drawer (ductone/c1#24933, ductone/c1#25052): the old 3-option "Add connector" flow (unmanaged app / managed app / new managed app + single owner) is replaced by a guided drawer: choose destination (new app / existing app) → optionally link to an application discovered from your identity provider → name/description → owners (multi-owner picker) → Add.

Both features are live in production. This PR brings the connector's own docs source in line with what's already merged in ConductorOne/docs (see ConductorOne/docs#527 and ConductorOne/docs#528), so the next sync doesn't reintroduce the stale flow.

Corrections were verified against the actual drawer code and applied directly to this file — not reapplied as a blind patch, since source docs can drift from what's synced into the docs site.

Test plan

  • Preview build looks correct

- Apps > Connectors replaces Integrations > Connectors in the admin
  nav (c1#24648).
- The Add connector walkthrough now reflects the new guided drawer:
  choose destination (new app / existing app) -> optional IdP link
  -> name/description -> owners -> Add (c1#24933, c1#25052).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Comment thread docs/connector.mdx

[This connector can sync secrets](/product/admin/inventory) and display them on the **Inventory** page.

[This connector syncs non-human identities](/product/admin/nhi) and displays them on the **Identities overview** dashboard.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: This non-human-identities claim is a scope addition beyond the two changes described in the PR summary (nav path + Add connector drawer). I found no explicit non-human/service-account modeling in the connector code (no WithAccountType/service-account trait option anywhere under pkg/), so please confirm the NHI dashboard actually surfaces this connector's data — presumably via IAM roles and access-key secrets — before publishing.

@github-actions

Copy link
Copy Markdown
Contributor

Connector PR Review: docs: update admin nav path and Add connector flow

Blocking Issues: 0 | Suggestions: 2 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base 46de3aea8b85.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness issues; this is a docs-only change to docs/connector.mdx with no Go, config, or dependency changes, so there is no code risk surface. All three Integrations > Connectors nav references were updated consistently to Apps > Connectors, and each of the three rewritten <Steps> blocks is well-formed MDX with a coherent destination, IdP-link, name/description, owners, Add sequence. There were no prior review findings on this PR; two non-blocking suggestions are noted below.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • docs/connector.mdx:39 - The new non-human-identities line is a scope addition not described in the PR summary, and no service-account/NHI modeling exists in the connector code; confirm the claim before publishing (low-medium confidence).
  • docs/connector.mdx:194,209,414,428,867,886 - The EXTERNAL_ID_FROM_C1_INTEGRATIONS_PAGE placeholder still encodes the old Integrations nav name that this PR renames (low confidence; cosmetic, and the token is used consistently, including as a Terraform variable name).
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `docs/connector.mdx`:
- Around line 39: The newly added non-human-identities sentence, which links to /product/admin/nhi and points readers at the **Identities overview** dashboard, is a scope addition beyond the two changes the PR description covers (admin nav path and the Add connector drawer). No non-human-identity or service-account modeling was found in the connector Go code under `pkg/` (no `WithAccountType` or service-account trait option anywhere in the package). Confirm that this connector's data (presumably IAM roles and access-key secrets) actually surfaces on that dashboard; if it does, mention this addition in the PR description so reviewers know it is intentional. If it does not, remove the line.
- Around lines 194, 209, 414, 428, 867, 886: The placeholder token `EXTERNAL_ID_FROM_C1_INTEGRATIONS_PAGE` (and the matching Terraform variable of the same name) still encodes the old Integrations nav label that this PR renames to Apps. Optionally rename it to something nav-neutral such as `EXTERNAL_ID_FROM_C1` and update every occurrence together, including the prose that references it and the Terraform variable and var. usages, so the snippets stay internally consistent. Skip this if the placeholder name is fixed by an external template.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

@mindymo
mindymo merged commit d8e58a6 into main Sep 10, 2026
9 checks passed
@mindymo
mindymo deleted the docs/nav-and-create-connector-drawer branch September 10, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants