Skip to content

chore: update baton-sdk to v0.7.16#25

Open
gontzess wants to merge 5 commits intomainfrom
task-sdk-upgrade-batch-7
Open

chore: update baton-sdk to v0.7.16#25
gontzess wants to merge 5 commits intomainfrom
task-sdk-upgrade-batch-7

Conversation

@gontzess
Copy link
Copy Markdown

@gontzess gontzess commented Jan 27, 2026

Summary

  • Upgrade baton-sdk to v0.7.16
  • Upgrade Go to 1.25.2
  • Update .golangci.yml to v2 format
  • Add config generation (go:generate) with typed config struct
  • Fix noctx lint error (exec.Command to exec.CommandContext)

CI Status

  • go-lint: PASS
  • go-test: PASS
  • test: FAIL (missing 1Password credentials in CI - pre-existing infrastructure limitation)

Build Status

  • Local build: PASS (verified go build ./...)

Reviewer Comment

@btipling noted the integration test failure may be a real issue rather than missing credentials - needs investigation.

Test plan

  • Lint passes
  • Unit tests pass
  • Integration test requires 1Password credentials in CI

@gontzess gontzess requested a review from a team January 27, 2026 16:31
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jan 27, 2026

Walkthrough

Go version upgraded from 1.23.4 to 1.25.2 with significant dependency updates including baton-sdk v0.3.10 to v0.7.4 and otter to v2. Command invocations converted to context-aware variants. New generated configuration struct with accessor methods added alongside config schema refactoring with secret field markers.

Changes

Cohort / File(s) Summary
Go Module Management
go.mod
Go version bumped to 1.25.2; baton-sdk upgraded to v0.7.4; otter migrated to v2; multiple transitive dependencies updated/removed (dolthub/maphash, gammazero/deque, shoenig/go-m1cpu); indirect additions of ruleguard, Masterminds/semver/v3, gopsutil/v4
Client Command Execution
pkg/client/client.go
All exec.Command invocations replaced with exec.CommandContext for context-aware cancellation support across local account retrieval, account addition, sign-in, and executeCommand methods
Configuration Schema & Generation
pkg/config/conf.gen.go, pkg/config/config.go
New generated Onepassword struct with mapstructure-tagged fields and type-specific accessor methods (GetString, GetInt, GetBool, GetStringSlice, GetStringMap); ConfigurationSchema removed and replaced with Config variable; KeyField and PasswordField marked with WithIsSecret(true)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Dependencies hop to newer ground,
Context flows where commands are found,
Secrets whisper through config's art,
Generated structs with beating heart! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions updating baton-sdk to v0.7.16, but the PR objectives and file changes show the actual version updated is v0.7.4. Additionally, the PR encompasses multiple significant changes beyond just the SDK upgrade, including Go version bump to 1.25.2, migration from Viper-based config to typed config struct, and context-aware command execution fixes. Update the title to accurately reflect the main changes, such as 'chore: upgrade baton-sdk to v0.7.4 and Go to 1.25.2' or 'chore: upgrade dependencies and migrate to typed config'. The version discrepancy (v0.7.16 vs v0.7.4) must be corrected.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task-sdk-upgrade-batch-7

Comment @coderabbitai help to get the list of available commands and usage tips.

@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch 2 times, most recently from afee0ef to 064eaa9 Compare January 27, 2026 17:15
@gontzess gontzess changed the title chore: upgrade baton-sdk to v0.7.3 and Go to 1.25.2 Upgrade baton-sdk to v0.7.4 and Go to 1.25.2 Jan 27, 2026
@gontzess gontzess marked this pull request as draft January 27, 2026 18:59
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch 2 times, most recently from 3cc1413 to 1ddc092 Compare January 27, 2026 20:23
@gontzess gontzess force-pushed the task-sdk-upgrade-batch-7 branch from 1ddc092 to d60c277 Compare January 27, 2026 21:33
@gontzess gontzess marked this pull request as ready for review January 27, 2026 22:11
@btipling
Copy link
Copy Markdown

I don't think this integration test is failing due to missing credentials. That looks like a real issue maybe

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gontzess gontzess changed the title Upgrade baton-sdk to v0.7.4 and Go to 1.25.2 chore: update baton-sdk to v0.7.16 Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants