CMP-4340: fix copy-paste variable reference in soft_nodefs_available rule#14838
Open
abushkin-redhat wants to merge 1 commit into
Open
CMP-4340: fix copy-paste variable reference in soft_nodefs_available rule#14838abushkin-redhat wants to merge 1 commit into
abushkin-redhat wants to merge 1 commit into
Conversation
Collaborator
Author
|
/ok-to-test |
abushkin-redhat
force-pushed
the
cmp-4340-eviction-consolidation
branch
from
308786f to
e2f28d1
Compare
|
@abushkin-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
copy-paste bug was fixed in
kubelet_eviction_thresholds_set_soft_nodefs_available/rule.ymlwherexccdf_variable: var_event_record_qps(from a different rule) was replaced with the correct values block.This was found while investigating CMP-4340 (kubelet eviction threshold remediation failures). During end-to-end testing of the scanner emptyDir fix (ComplianceAsCode/compliance-operator#1255), 4 of 5 soft eviction rules passed correctly on both initial scan and rescan, but
soft_nodefs_availableconsistently failed despite the kubelet having the correct value. ARF analysis confirmed the scanner read500Mifrom the kubelet config but the OVAL comparison againstvar_event_record_qps(value0) caused the false failure.Fix:
Replace
xccdf_variable: var_event_record_qpswith the correctvaluesblock using pattern match, consistent with all 9 other eviction threshold rules.