Display critical facility details and min map#557
Open
Mloweedgar wants to merge 5 commits intodevelopfrom
Open
Display critical facility details and min map#557Mloweedgar wants to merge 5 commits intodevelopfrom
Mloweedgar wants to merge 5 commits intodevelopfrom
Conversation
…view to render map
remove react-map-gl and install react-leaflet and leaflet
…re/critical_facility_details_view
… protypes definition
BenMaruchu
requested changes
Jun 19, 2021
Comment on lines
+1
to
+68
| // import React, { Component } from 'react'; | ||
| // // eslint-disable-next-line import/no-extraneous-dependencies | ||
| // import 'mapbox-gl/dist/mapbox-gl.css'; | ||
| // import PropTypes from 'prop-types'; | ||
| // import MapGL, { Source, Layer, NavigationControl } from 'react-map-gl'; | ||
| // | ||
| // const TOKEN = process.env.REACT_APP_MAPBOX_ACCESS_TOKEN; | ||
| // export const dataLayer = { | ||
| // id: 'points', | ||
| // type: 'symbol', | ||
| // source: 'points', | ||
| // layout: { | ||
| // 'icon-image': 'marker-15', | ||
| // }, | ||
| // }; | ||
| // | ||
| // class MapPoint extends Component { | ||
| // // eslint-disable-next-line react/static-property-placement | ||
| // static propTypes = { | ||
| // geometry: PropTypes.shape({ | ||
| // type: PropTypes.string.isRequired, | ||
| // coordinates: PropTypes.arrayOf(PropTypes.any).isRequired, | ||
| // }).isRequired, | ||
| // }; | ||
| // | ||
| // // eslint-disable-next-line react/state-in-constructor | ||
| // state = { | ||
| // viewport: { | ||
| // latitude: -6.8042752, | ||
| // longitude: 39.247872, | ||
| // zoom: 13, | ||
| // }, | ||
| // }; | ||
| // | ||
| // render() { | ||
| // const { viewport } = this.state; | ||
| // const { geometry } = this.props; | ||
| // return ( | ||
| // <MapGL | ||
| // mapStyle="mapbox://styles/mapbox/light-v9" | ||
| // mapboxApiAccessToken={TOKEN} | ||
| // width="100%" | ||
| // height="94vh" | ||
| // /* eslint-disable-next-line react/jsx-props-no-spreading,react/destructuring-assignment */ | ||
| // {...viewport} | ||
| // onViewportChange={(updatedViewPort) => { | ||
| // const { latitude, longitude, zoom } = updatedViewPort; | ||
| // this.setState({ viewport: { latitude, longitude, zoom } }); | ||
| // }} | ||
| // > | ||
| // <div style={{ position: 'absolute' }}> | ||
| // <NavigationControl /> | ||
| // </div> | ||
| // <Source | ||
| // type="geojson" | ||
| // data={{ | ||
| // type: 'Feature', | ||
| // geometry, | ||
| // }} | ||
| // > | ||
| // {/* eslint-disable-next-line react/jsx-props-no-spreading */} | ||
| // <Layer {...dataLayer} /> | ||
| // </Source> | ||
| // </MapGL> | ||
| // ); | ||
| // } | ||
| // } | ||
| // export default MapPoint; |
Member
There was a problem hiding this comment.
Hello @Mloweedgar , do we need this code , we can remove it since the history is on github
Comment on lines
+1
to
+62
| // import React, { Component } from 'react'; | ||
| // // eslint-disable-next-line import/no-extraneous-dependencies | ||
| // import 'mapbox-gl/dist/mapbox-gl.css'; | ||
| // import PropTypes from 'prop-types'; | ||
| // import MapGL, { Source, Layer, NavigationControl } from 'react-map-gl'; | ||
| // | ||
| // const TOKEN = process.env.REACT_APP_MAPBOX_ACCESS_TOKEN; | ||
| // export const dataLayer = { | ||
| // id: 'data', | ||
| // type: 'fill', | ||
| // paint: { | ||
| // 'fill-color': '#088', | ||
| // 'fill-opacity': 0.2, | ||
| // }, | ||
| // }; | ||
| // | ||
| // class MapPolygon extends Component { | ||
| // // eslint-disable-next-line react/static-property-placement | ||
| // static propTypes = { | ||
| // geometry: PropTypes.shape({ | ||
| // type: PropTypes.string.isRequired, | ||
| // coordinates: PropTypes.arrayOf(PropTypes.any).isRequired, | ||
| // }).isRequired, | ||
| // }; | ||
| // | ||
| // // eslint-disable-next-line react/state-in-constructor | ||
| // state = { | ||
| // viewport: { | ||
| // latitude: -6.8042752, | ||
| // longitude: 39.247872, | ||
| // zoom: 13, | ||
| // }, | ||
| // }; | ||
| // | ||
| // render() { | ||
| // const { viewport } = this.state; | ||
| // const { geometry } = this.props; | ||
| // return ( | ||
| // <MapGL | ||
| // mapStyle="mapbox://styles/mapbox/light-v9" | ||
| // mapboxApiAccessToken={TOKEN} | ||
| // width="100%" | ||
| // height="94vh" | ||
| // /* eslint-disable-next-line react/jsx-props-no-spreading,react/destructuring-assignment */ | ||
| // {...viewport} | ||
| // onViewportChange={(updatedViewPort) => { | ||
| // const { latitude, longitude, zoom } = updatedViewPort; | ||
| // this.setState({ viewport: { latitude, longitude, zoom } }); | ||
| // }} | ||
| // > | ||
| // <div style={{ position: 'absolute' }}> | ||
| // <NavigationControl /> | ||
| // </div> | ||
| // <Source type="geojson" data={geometry}> | ||
| // {/* eslint-disable-next-line react/jsx-props-no-spreading */} | ||
| // <Layer {...dataLayer} /> | ||
| // </Source> | ||
| // </MapGL> | ||
| // ); | ||
| // } | ||
| // } | ||
| // export default MapPolygon; |
Member
There was a problem hiding this comment.
same here we can always delete it and get it back from VCS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.