Skip to content

chore: bump services versions#5

Open
VinneyJ wants to merge 7 commits into
masterfrom
bump-version
Open

chore: bump services versions#5
VinneyJ wants to merge 7 commits into
masterfrom
bump-version

Conversation

@VinneyJ

@VinneyJ VinneyJ commented Mar 10, 2025

Copy link
Copy Markdown

bumped versions from 6.1.1 to 6.5.3
removed restart policy for uniformity with the original and the deployed version.
added import document functionality.

@VinneyJ VinneyJ requested a review from a team March 10, 2025 09:43
@kilemensi

Copy link
Copy Markdown
Member

👍🏽 @VinneyJ

Can you add a description to this PR? I see we're dropping restart_policy etc.

@kilemensi

Copy link
Copy Markdown
Member

Thanks for the update @VinneyJ .

I'll let @thepsalmist and the rest of the @CodeForAfrica/tech give the final review but: If we're deploying with docker swarm, remember docker stack deploy doesn't understand (and hence ignores) restart. If you want a restart policy then you have to use restart_policy.

@VinneyJ

VinneyJ commented Mar 10, 2025

Copy link
Copy Markdown
Author

Thanks, @kilemensi. That makes sense. I will have to have the policy back, including in the production stack itself.

@thepsalmist thepsalmist left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @VinneyJ

@kilemensi

Copy link
Copy Markdown
Member

Just had a quick look @VinneyJ and the code still uses restart instead of restart_policy. Per my previous comment, docker stack/swarm doesn't support restart.

@VinneyJ

VinneyJ commented Mar 13, 2025

Copy link
Copy Markdown
Author

I had modified the restart policy instead of the restart setting, which caused the services with the new policy to fail to start well. However, due to time constraints, I had to revert the changes to ensure everything ran smoothly in production as I plan to revisit the issue and test and debug it locally first. @kilemensi

@kilemensi

kilemensi commented Mar 13, 2025

Copy link
Copy Markdown
Member

However, due to time constraints, I had to revert ...

I like things simple @VinneyJ: Either we're ready to proceed or not. This PR looks like it's not ready to merge to me.

Option 1: Remove restart because docker swarm doesn't support it and leaving it in compose.yaml gives the impression that it's actually being used while it's not (i.e. someone will wonder why the services are not started in order specified). Create a separate issue to track whatever issue you need to debug with restart_policy so this PR can proceed.
Option 2: Move the PR back to draft, debug the restart_policy issue and when you're ready, open the PR again, pinging the team for review.

@VinneyJ

VinneyJ commented Mar 13, 2025

Copy link
Copy Markdown
Author

Okay cool, cool. I will go with option 1. @kilemensi

Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml
Comment thread docker-compose.yml Outdated
@VinneyJ VinneyJ requested a review from kilemensi March 25, 2025 11:30
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
@VinneyJ VinneyJ requested a review from kilemensi March 27, 2025 09:18
Comment thread Makefile Outdated
Comment thread Makefile
Comment thread docker-compose.yml Outdated
@VinneyJ VinneyJ requested a review from kilemensi March 27, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants