Skip to content

database: change datetime into start and end time strings#53

Draft
abhiramtilakiiit wants to merge 7 commits into
masterfrom
add_duration
Draft

database: change datetime into start and end time strings#53
abhiramtilakiiit wants to merge 7 commits into
masterfrom
add_duration

Conversation

@abhiramtilakiiit

@abhiramtilakiiit abhiramtilakiiit commented May 22, 2024

Copy link
Copy Markdown
Contributor

Overview

The current way of storing DateTime elements in the database is causing database corruption.
Storing strings in the datetime period feels more safe and also prevents other timezone problems like #48
from happening.

Changes Proposed

  1. Store times as string without any timezone data, assuming everything as IST.
  2. Store timings of event as two variables, rather than a tuple, to prevent any unwanted confusion in db
  3. Store duration of the event for security for now. It will not be used currently anywhere, except if needed to restore corruption in db in times of the events

Linked PRs

@bhavberi bhavberi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the timezone message/information in the Event Form (so that user knows in what timezone they should select the time)

Comment thread src/components/events/EventForm.jsx
@bhavberi bhavberi force-pushed the master branch 2 times, most recently from 5fbef6d to a219ac2 Compare May 27, 2024 19:20
@bhavberi bhavberi force-pushed the master branch 5 times, most recently from 860f48e to e1d6e79 Compare June 15, 2024 13:18
@bhavberi bhavberi force-pushed the master branch 5 times, most recently from f6e1bae to 4e77c41 Compare July 9, 2024 21:10
@bhavberi bhavberi marked this pull request as draft July 11, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants