feat: Add Trilogy adapter support with MariaDB 12.0+#134
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for the Trilogy adapter (GitHub's MariaDB/MySQL driver) to enable testing with_advisory_lock functionality across three different database adapters: PostgreSQL, MySQL2, and Trilogy with MariaDB 12.0+.
- Introduces Trilogy models (TrilogyTag, TrilogyTagAudit, TrilogyLabel) that mirror existing PostgreSQL and MySQL models
- Updates all existing test suites to include Trilogy adapter test cases
- Configures CI workflow to test against MariaDB alongside existing PostgreSQL and MySQL databases
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/with_advisory_lock/thread_test.rb | Adds TrilogyThreadTest class for thread-based lock testing |
| test/with_advisory_lock/shared_test.rb | Adds TrilogySharedLocksTest for shared lock behavior validation |
| test/with_advisory_lock/parallelism_test.rb | Adds TrilogyParallelismTest for concurrent lock testing |
| test/with_advisory_lock/multi_adapter_test.rb | Extends isolation tests to verify all three adapters don't interfere |
| test/test_helper.rb | Adds DATABASE_URL_TRILOGY environment variable validation |
| test/sanity_check_test.rb | Extends database isolation and adapter verification tests |
| test/dummy/lib/tasks/trilogy.rake | Provides Rake tasks for Trilogy database setup and schema loading |
| test/dummy/db/trilogy_schema.rb | Defines database schema for Trilogy test models |
| test/dummy/config/database.yml | Adds Trilogy database configuration |
| test/dummy/app/models/trilogy_*.rb | Creates Trilogy model classes mirroring existing test structure |
| .github/workflows/ci.yml | Adds MariaDB service and Trilogy environment configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
13f09a6 to
efd7f7c
Compare
d9d10fd to
0be7e31
Compare
0be7e31 to
28b8c98
Compare
348084f to
e29e569
Compare
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables testing with_advisory_lock across three different database adapters:
fixes #129