Bound the provider compatibility jobs to 20 minutes - #881
Conversation
The pmp tests fetch reference data over the network with no socket timeout, so a stalled download hung the job for hours against the default six hour limit.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe provider compatibility workflow now limits the ChangesProvider compatibility workflow
Merge Risk: ⚪ Minimal · up to This change bounds provider compatibility jobs to 20 minutes so stalled CI work fails fast instead of holding a runner; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The pmp job in Provider Compatibility hung twice on #880, once for 21 hours, printing no output past the command line. It is the only provider whose unit tests download reference data (
packages/climate-ref-pmp/conftest.pyfetches thepmp-climatologyregistry from obs4ref), pooch is used without a socket timeout, and the registry retries ten times. A stalled download therefore runs until GitHub's default six hour limit. This adds an explicit 20 minute cap so a stalled fetch fails fast instead of holding a runner. The jobs currently finish in one to four minutes, so there is plenty of headroom. This won't stop the stall itself, but it stops it eating a runner for the rest of the day.Summary by CodeRabbit