Skip to content

Bound the provider compatibility jobs to 20 minutes - #881

Merged
lewisjared merged 1 commit into
mainfrom
ci/provider-compat-timeout
Aug 17, 2026
Merged

Bound the provider compatibility jobs to 20 minutes#881
lewisjared merged 1 commit into
mainfrom
ci/provider-compat-timeout

Conversation

@lewisjared

@lewisjared lewisjared commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The pmp job in Provider Compatibility hung twice on #880, once for 21 hours, printing no output past the command line. It is the only provider whose unit tests download reference data (packages/climate-ref-pmp/conftest.py fetches the pmp-climatology registry from obs4ref), pooch is used without a socket timeout, and the registry retries ten times. A stalled download therefore runs until GitHub's default six hour limit. This adds an explicit 20 minute cap so a stalled fetch fails fast instead of holding a runner. The jobs currently finish in one to four minutes, so there is plenty of headroom. This won't stop the stall itself, but it stops it eating a runner for the rest of the day.

Summary by CodeRabbit

  • Chores
    • Extended the provider compatibility check timeout to 20 minutes, allowing longer-running checks to complete successfully.

The pmp tests fetch reference data over the network with no socket timeout, so a stalled
download hung the job for hours against the default six hour limit.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2869133c-f47b-4337-a962-8427b3ea7f73

📥 Commits

Reviewing files that changed from the base of the PR and between f825918 and c9dde20.

📒 Files selected for processing (1)
  • .github/workflows/provider-compat.yml

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The provider compatibility workflow now limits the provider-compat job to 20 minutes.

Changes

Provider compatibility workflow

Layer / File(s) Summary
Set provider compatibility timeout
.github/workflows/provider-compat.yml
The provider-compat job now sets timeout-minutes to 20.

Merge Risk: ⚪ Minimal · up to c9dde

This change bounds provider compatibility jobs to 20 minutes so stalled CI work fails fast instead of holding a runner; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: adding a 20-minute limit to provider compatibility jobs.
Description check ✅ Passed The description explains the cause, impact, implementation, and expected job duration, but it omits the template checklist and its confirmations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/provider-compat-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lewisjared
lewisjared merged commit 8991c0e into main Aug 17, 2026
24 of 26 checks passed
@lewisjared
lewisjared deleted the ci/provider-compat-timeout branch August 17, 2026 10:39
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
core 93.75% <ø> (ø)
providers 87.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant