Add deprecations to avoid breaking interface - #768
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
=======================================
Coverage 92.86% 92.86%
=======================================
Files 56 56
Lines 2889 2889
=======================================
Hits 2683 2683
Misses 206 206
🚀 New features to boost your workflow:
|
Member
|
So thats why ClimaAtmos no longer works for me with the new CM :) Thank you for fixing it! |
trontrytel
approved these changes
Jul 30, 2026
trontrytel
left a comment
trontrytel
left a comment
Member
There was a problem hiding this comment.
Would be good to add a test for it. It may be deprecated, but thats how Atmos is using the library now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR #767 would require a minor (breaking) release because it removed the toml-based constructors for 1M options ( e.g.
CloudLiquidFormation(::CP.ParamDict)). This PR adds the constructors back in with deprecations.