Avoid SIGPIPE (error 141) in auto-cancel Run Step example#73
Open
davidjb wants to merge 1 commit intoCircleCI-Public:mainfrom
Open
Avoid SIGPIPE (error 141) in auto-cancel Run Step example#73davidjb wants to merge 1 commit intoCircleCI-Public:mainfrom
davidjb wants to merge 1 commit intoCircleCI-Public:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example shown at https://support.circleci.com/hc/en-us/articles/360055901372-Auto-Cancel-Re-Run-if-Newer-Commit-Exists is susceptible to SIGPIPE (Bash exit code 141) errors because of the mixture of commands. In short, use of
head -n 1exits before thegit showcommand ends, becausegit showis still busy outputting the diff of a given commit. This also created a race condition where shorter diffs would not trigger the issue but longer ones would. This is solved with the changes in this PR, by not outputting the patches.This also cleans up the first "latest commit" command by simplifying it to avoid needing grep. By doing so, it focussing on
--headsrather than potentially tags as well and fixes a situation wheregrepwould match multiple branches -- e.g.devmatchesanother-dev, leading to incorrect tests.