refactor: improve temperature and top_p parameter handling #11663
+198
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
isNotSupportTemperatureAndTopPto check if models support temperature/top_p parametersAfter this PR:
isSupportTemperatureModelandisSupportTopPModelisTemperatureTopPMutuallyExclusiveModelto explicitly handle Claude 4.5 reasoning models' constraintisSupportXinstead ofisNotSupportX)Why we need it and why it was done in this way
Motivation:
isNotSupportTemperatureAndTopPwas semantically ambiguousTradeoffs made:
Alternatives considered:
Breaking changes
None.
Special notes for your reviewer
Key changes:
src/renderer/src/config/models/utils.ts:isSupportTemperatureModel()- checks if model supports temperature parameterisSupportTopPModel()- checks if model supports top_p parameterisTemperatureTopPMutuallyExclusiveModel()- checks if temperature and top_p are mutually exclusive (Claude 4.5)isNotSupportTemperatureAndTopP()with backward compatibilitysrc/renderer/src/aiCore/legacy/clients/BaseApiClient.ts:getTemperature()andgetTopP()to use new functionssrc/renderer/src/aiCore/prepareParams/modelParameters.ts:Test coverage:
isSupportTemperatureModelisSupportTopPModelisTemperatureTopPMutuallyExclusiveModelTesting:
Checklist
Release note