Skip to content

Conversation

@EurFelux
Copy link
Collaborator

What this PR does

Before this PR:

After this PR:

image

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Breaking changes

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note


Add new SelectionBuiltinActionItem type to better type builtin actions
Update defaultActionItems to use new type with const assertion
Add assistant model name display when available to provide more context about the selected action
- Replace FC type with direct props typing in ActionTranslate
- Add zod schema and type guards for builtin action items
- Enhance model selection logic in SelectionActionApp
@EurFelux EurFelux requested a review from 0xfullex as a code owner November 25, 2025 09:57
@EurFelux EurFelux changed the base branch from main to v2 November 25, 2025 09:57
@EurFelux EurFelux added the v2 label Nov 25, 2025
@0xfullex
Copy link
Collaborator

0xfullex commented Nov 25, 2025

Note

This issue/comment/review was translated by Claude.

  • Based on the current product design, adding this is unnecessary and only increases complexity
  • That said, if we were to add it, the current location isn't appropriate: 1) the width isn't sufficient, 2) this space is valuable, 3) we need to consider the possibility of switching models in the future

Original Content
  • 按现在的产品设计,加上没必要,徒增复杂度
  • 退一步,要加也可以,但是现在加的地方不合适,1是宽度不够,2是这里位置宝贵,3是考虑未来可以切换模型怎么办

@EurFelux
Copy link
Collaborator Author

EurFelux commented Nov 25, 2025

Note

This issue/comment/review was translated by Claude.

Indeed, it's fine not to add it. The motivation for this change is that users typically don't report which provider and model they're using when reporting bugs, and might not even know which models the various built-in actions of the selection assistant use. Adding this could save some communication time.


Original Content

的确不加也可以。这个改动的动机是,用户通常不会在报告bug时同时报告使用什么provider什么model,甚至可能完全不知道划词助手的各个内置action会使用什么模型。加上的话可以省去一些沟通的时间。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants