Skip to content

fix: foreign network wallet listing#6555

Merged
LesnyRumcajs merged 1 commit intomainfrom
fix-wallet-listing
Feb 7, 2026
Merged

fix: foreign network wallet listing#6555
LesnyRumcajs merged 1 commit intomainfrom
fix-wallet-listing

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Feb 6, 2026

Summary of changes

Changes introduced in this pull request:

  • Fixed listing of wallets belonging to different networks in forest-wallet list command (and the Filecoin.WalletList RPC method). This incorrectly showed, e.g., calibnet wallets when running a mainnet node. Under the hood they're actually the same, but this could cause confusion and issues with some clients. It also resulted in errors trying to export a wallet that belongs to a different network.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed incorrect listing of wallets from different networks (e.g., calibnet and mainnet) appearing together
    • Resolved export errors when wallets belong to different networks

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

The PR fixes incorrect wallet listing in forest-wallet where wallets from different networks appeared together. The fix modifies address parsing in the list_addrs function to use StrictAddress::from_str instead of Address::from_str, ensuring stricter validation during wallet enumeration.

Changes

Cohort / File(s) Summary
Bug Fix Documentation
CHANGELOG.md
Added changelog entry for #6555 documenting the fix for wallet list output showing wallets from different networks.
Wallet Address Parsing
src/key_management/wallet.rs
Changed address parsing in list_addrs from Address::from_str to StrictAddress::from_str, converting the result back to Address via .into() for stricter network validation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: foreign network wallet listing' directly and clearly describes the main change: preventing wallets from foreign/different networks from being listed.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-wallet-listing

Comment @coderabbitai help to get the list of available commands and usage tips.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 6, 2026 16:45
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner February 6, 2026 16:45
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team February 6, 2026 16:45
@LesnyRumcajs LesnyRumcajs added the RPC requires calibnet RPC checks to run on CI label Feb 6, 2026
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 6, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 9a56617 Feb 7, 2026
49 of 73 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-wallet-listing branch February 7, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants