Skip to content

Enable support for Filecoin.EthNewFilter V2#6513

Draft
sudo-shashank wants to merge 10 commits intomainfrom
shashank/enable-eth-new-filter-v2
Draft

Enable support for Filecoin.EthNewFilter V2#6513
sudo-shashank wants to merge 10 commits intomainfrom
shashank/enable-eth-new-filter-v2

Conversation

@sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Feb 3, 2026

Summary of changes

Changes introduced in this pull request:

  • Enabled support for Filecoin.EthNewFilter V2 as Safe and Finalized are not yet implemented in lotus.

Reference issue to close (if applicable)

Closes #6304

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • New Features
    • Filecoin.EthNewFilter is now enabled and reachable via the API v2 endpoints. This makes the method available to clients using v2 without changing its parameters, return values, or runtime behavior. No other functional changes were introduced.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

Enable Filecoin.EthNewFilter for API v2 routing by changing its API_PATHS from ApiPaths::all() to ApiPaths::all_with_v2() and add a changelog entry documenting the change.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md
Add changelog entry noting Filecoin.EthNewFilter enabled for API v2.
RPC Method Configuration
src/rpc/methods/eth.rs
Update EthNewFilter const API_PATHS from ApiPaths::all() to ApiPaths::all_with_v2() to enable v2 routing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
  • hanabi1224
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Enable support for Filecoin.EthNewFilter V2' directly matches the main change: updating API_PATHS for EthNewFilter from all() to all_with_v2().
Linked Issues check ✅ Passed The PR addresses issue #6304 for enabling RPC v2 support for Filecoin.EthNewFilter by updating the API_PATHS constant and documenting the change in the changelog.
Out of Scope Changes check ✅ Passed All changes are directly related to enabling V2 API support for EthNewFilter: CHANGELOG entry, API_PATHS update, and no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/enable-eth-new-filter-v2

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added RPC requires calibnet RPC checks to run on CI labels Feb 4, 2026
@sudo-shashank sudo-shashank marked this pull request as ready for review February 4, 2026 11:36
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 4, 2026 11:36
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and akaladarshi and removed request for a team February 4, 2026 11:36
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.32%. Comparing base (b5c8f56) to head (af6ebc9).

Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth.rs 69.55% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c8f56...af6ebc9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hanabi1224
hanabi1224 previously approved these changes Feb 4, 2026
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@sudo-shashank sudo-shashank removed this pull request from the merge queue due to a manual request Feb 4, 2026
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2026
@hanabi1224
Copy link
Contributor

I believe this PR will fail the openrpc test enabled by #6523. Let's hold until the other one is merged.

@sudo-shashank sudo-shashank marked this pull request as draft February 6, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RPC v2] Filecoin.EthNewFilter

2 participants